From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Deti Fliegl <deti@fliegl.de>
Subject: Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD
Date: Sun, 6 Feb 2011 12:18:11 +0100 [thread overview]
Message-ID: <20110206121811.3f05c3b1@stein> (raw)
In-Reply-To: <201102051417.22874.hverkuil@xs4all.nl>
On Feb 05 Hans Verkuil wrote:
> The following changes since commit ffd14aab03dbb8bb1bac5284603835f94d833bd6:
> Devin Heitmueller (1):
> [media] au0828: fix VBI handling when in V4L2 streaming mode
>
> are available in the git repository at:
>
> ssh://linuxtv.org/git/hverkuil/media_tree.git v4l1
>
> Hans Verkuil (4):
> se401/usbvideo: remove last V4L1 drivers
> dabusb: remove obsolete driver
> firedtv: remove dependency on the deleted ieee1394 stack.
> v4l: removal of old, obsolete ioctls.
On commit f02c316436eef3baf349c489545edc7ade419ff6 "firedtv: remove
dependency on the deleted ieee1394 stack.":
The diff is correct and runtime-tested it. But, as discussed, the
changelog is wrong and the shortlog somewhat misleading. I suggest
something along the lines of:
----8<----
firedtv: remove obsolete ieee1394 backend code
drivers/ieee1394/ has been removed in Linux 2.6.37. The corresponding
backend code in firedtv is no longer built in now and can be deleted.
Firedtv continues to work with drivers/firewire/.
Also, fix a Kconfig menu comment: Removal of CONFIG_IEEE1394 made the
"Supported FireWire (IEEE 1394) Adapters" comment disappear; bring it back
with corrected dependency.
---->8----
A minor note: firedtv-dvb.c::fdtv_init() can now be shortened further,
and firedtv-fw.c::fdtv_fw_exit() can receive an __exit annotation.
However, these changes can wait for (or will be superseded by) a subsequent
simplification of firedtv which throws out the fdtv->backend abstraction.
I tend to think that the three parts of firedtv-fw.c (asynchronous I/O,
isochronous I/O, device probe/update/removal) can be moved into
firedtv-avc.c, -fe.c, and -dvb.c. I will post something.
If you rewrite the changelog, you can add
Reviewed-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
if you like.
--
Stefan Richter
-=====-==-== --=- --==-
http://arcgraph.de/sr/
prev parent reply other threads:[~2011-02-06 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 13:17 [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD Hans Verkuil
2011-02-05 14:29 ` Stefan Richter
2011-02-05 14:48 ` Hans Verkuil
2011-02-06 11:18 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110206121811.3f05c3b1@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=deti@fliegl.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox