From: Mark Zimmerman <markzimm@frii.com>
To: Andy Walls <awalls@md.metrocast.net>
Cc: linux-media@vger.kernel.org, Jarod Wilson <jarod@redhat.com>
Subject: Re: [get-bisect results]: DViCO FusionHDTV7 Dual Express I2C write failed
Date: Sat, 12 Feb 2011 10:03:05 -0700 [thread overview]
Message-ID: <20110212170305.GA30334@io.frii.com> (raw)
In-Reply-To: <1297529173.2413.32.camel@localhost>
On Sat, Feb 12, 2011 at 11:46:13AM -0500, Andy Walls wrote:
> On Sat, 2011-02-12 at 09:36 -0700, Mark Zimmerman wrote:
> > On Sat, Feb 12, 2011 at 11:27:27AM -0500, Andy Walls wrote:
> > > On Sat, 2011-02-12 at 08:29 -0700, Mark Zimmerman wrote:
> > > > On Tue, Dec 07, 2010 at 12:07:53PM -0700, Mark Zimmerman wrote:
> > > > > Greetings:
> > > > >
> > > > > I have a DViCO FusionHDTV7 Dual Express card that works with 2.6.35 but
> > > > > which fails to initialize with the latest 2.6.36 kernel. The firmware
> > > > > fails to load due to an i2c failure. A search of the archives indicates
> > > > > that this is not the first time this issue has occurred.
> > > > >
> > > > > What can I do to help get this problem fixed?
> > > > >
> > > > > Here is the dmesg from 2.6.35, for the two tuners:
> > > > >
> > > > > xc5000: waiting for firmware upload (dvb-fe-xc5000-1.6.114.fw)...
> > > > > xc5000: firmware read 12401 bytes.
> > > > > xc5000: firmware uploading...
> > > > > xc5000: firmware upload complete...
> > > > > xc5000: waiting for firmware upload (dvb-fe-xc5000-1.6.114.fw)...
> > > > > xc5000: firmware read 12401 bytes.
> > > > > xc5000: firmware uploading...
> > > > > xc5000: firmware upload complete..
> > > > >
> > > > > and here is what happens with 2.6.36:
> > > > >
> > > > > xc5000: waiting for firmware upload (dvb-fe-xc5000-1.6.114.fw)...
> > > > > xc5000: firmware read 12401 bytes.
> > > > > xc5000: firmware uploading...
> > > > > xc5000: I2C write failed (len=3)
> > > > > xc5000: firmware upload complete...
> > > > > xc5000: Unable to initialise tuner
> > > > > xc5000: waiting for firmware upload (dvb-fe-xc5000-1.6.114.fw)...
> > > > > xc5000: firmware read 12401 bytes.
> > > > > xc5000: firmware uploading...
> > > > > xc5000: I2C write failed (len=3)
> > > > > xc5000: firmware upload complete...
> > > > >
> > > >
> > > > I did a git bisect on this and finally reached the end of the line.
> > > > Here is what it said:
> > > >
> > > > qpc$ git bisect bad
> > > > 82ce67bf262b3f47ecb5a0ca31cace8ac72b7c98 is the first bad commit
> > > > commit 82ce67bf262b3f47ecb5a0ca31cace8ac72b7c98
> > > > Author: Jarod Wilson <jarod@redhat.com>
> > > > Date: Thu Jul 29 18:20:44 2010 -0300
> > > >
> > > > V4L/DVB: staging/lirc: fix non-CONFIG_MODULES build horkage
> > > >
> > > > Fix when CONFIG_MODULES is not enabled:
> > > >
> > > > drivers/staging/lirc/lirc_parallel.c:243: error: implicit declaration of function 'module_refcount'
> > > > drivers/staging/lirc/lirc_it87.c:150: error: implicit declaration of function 'module_refcount'
> > > > drivers/built-in.o: In function `it87_probe':
> > > > lirc_it87.c:(.text+0x4079b0): undefined reference to `init_chrdev'
> > > > lirc_it87.c:(.text+0x4079cc): undefined reference to `drop_chrdev'
> > > > drivers/built-in.o: In function `lirc_it87_exit':
> > > > lirc_it87.c:(.exit.text+0x38a5): undefined reference to `drop_chrdev'
> > > >
> > > > Its a quick hack and untested beyond building, since I don't have the
> > > > hardware, but it should do the trick.
> > > >
> > > > Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> > > > Signed-off-by: Jarod Wilson <jarod@redhat.com>
> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> > > >
> > > > :040000 040000 f645b46a07b7ff87a2c11ac9296a5ff56e89a0d0 49e50945ccf8e1c8567c049908890d2752443b72 M drivers
> > >
> > > Hmm. git log --patch 82ce67bf262b3f47ecb5a0ca31cace8ac72b7c98 shows the
> > > commit is completely unrealted.
> > >
> > > Please try and see if things are good or bad at commit
> > > 18a87becf85d50e7f3d547f1b7a75108b151374d:
> > >
> > > commit 18a87becf85d50e7f3d547f1b7a75108b151374d
> > > Author: Jean Delvare <khali@linux-fr.org>
> > > Date: Sun Jul 18 17:05:17 2010 -0300
> > >
> > > V4L/DVB: cx23885: i2c_wait_done returns 0 or 1, don't check for < 0 return v
> > >
> > > Function i2c_wait_done() never returns negative values, so there is no
> > > point in checking for them.
> > >
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > > Signed-off-by: Andy Walls <awalls@md.metrocast.net>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> > >
> > > Which is the first commit, prior to the one you found, that seems to me
> > > to have any direct bearing to I2C transactions.
> > >
> > > If that commit is good, then these commits in between would be my next
> > > likely suspects:
> > > e5514f104d875b3d28cbcd5d4f2b96ab2fca1e29
> > > dbe83a3b921328e12b2abe894fc692afba293d7f
> > >
> > > Regards,
> > > Andy
> > >
> >
> > Sorry to require so much hand holding, but I am new to all of this git
> > gymnastics. Would you mind sending me the correct git command to get
> > to a specific commit?
>
> It should just be
>
> $ git checkout 18a87becf85d50e7f3d547f1b7a75108b151374d
>
> or whatever the commit number git log shows you for the change I suspect
> is the problem.
>
>
> > Also, do I need to do a bisect reset?
>
> I wouldn't reset the git bisect yet. If you test a commit and it is
> good, you will want to mark it with 'git bisect good <commit-hash>', and
> if it is bad, you will want to mark it with 'git bisect bad
> <commit-hash>'
>
> BTW, can you provide the output of 'git bisect log' ?
>
I suspect I know why the bisect process went astray. Early on, I was
unable to get a successful build because of mismatch errors. Turning
off CONFIG_STAGING fixed this. If most of the changes were related to
staging then the bisect could have skipped the relevant change. Note
the unlikely string of 5 bad ones in a row at the end. Here is the
log:
git bisect start
# good: [9fe6206f400646a2322096b56c59891d530e8d51] Linux 2.6.35
git bisect good 9fe6206f400646a2322096b56c59891d530e8d51
# bad: [f6f94e2ab1b33f0082ac22d71f66385a60d8157f] Linux 2.6.36
git bisect bad f6f94e2ab1b33f0082ac22d71f66385a60d8157f
# good: [78417334b5cb6e1f915b8fdcc4fce3f1a1b4420c] Merge branch 'bkl/core' of git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing
git bisect good 78417334b5cb6e1f915b8fdcc4fce3f1a1b4420c
# bad: [14a4fa20a10d76eb98b7feb25be60735217929ba] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6
git bisect bad 14a4fa20a10d76eb98b7feb25be60735217929ba
# good: [8196867c74890ccdf40a2b5e3e173597fbc4f9ac] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/bcopeland/omfs
git bisect good 8196867c74890ccdf40a2b5e3e173597fbc4f9ac
# bad: [3d30701b58970425e1d45994d6cb82f828924fdd] Merge branch 'for-linus' of git://neil.brown.name/md
git bisect bad 3d30701b58970425e1d45994d6cb82f828924fdd
# good: [9895850b23886e030cd1e7241d5529a57e969c3d] Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
git bisect good 9895850b23886e030cd1e7241d5529a57e969c3d
# good: [de75d60d5ea235e6e09f4962ab22541ce0fe176a] block: make sure that REQ_* types are seen even with CONFIG_BLOCK=n
git bisect good de75d60d5ea235e6e09f4962ab22541ce0fe176a
# bad: [6dd5aff3cab284556952d96f1112b17299e126d8] V4L/DVB: v4l2-ctrls: Whitespace cleanups
git bisect bad 6dd5aff3cab284556952d96f1112b17299e126d8
# good: [efce8ca3c5d8a35018f801d687396e1911cfc868] V4L/DVB: staging/lirc: fix Kconfig dependencies
git bisect good efce8ca3c5d8a35018f801d687396e1911cfc868
# bad: [9bde9f263e958b0d588aada03854fcc0f0c88b86] V4L/DVB: uvcvideo: Drop corrupted compressed frames
git bisect bad 9bde9f263e958b0d588aada03854fcc0f0c88b86
# bad: [39b2c0687b238d8bce19d5e8c0c8dc4e7fe50ed4] V4L/DVB: IR: JVC: make repeat work
git bisect bad 39b2c0687b238d8bce19d5e8c0c8dc4e7fe50ed4
# bad: [2c1101d5aeddda7bd0dd03bddea7aed6dbf80074] V4L/DVB: IR: put newly ported streamzap driver in proper home
git bisect bad 2c1101d5aeddda7bd0dd03bddea7aed6dbf80074
# bad: [7c294402d58e22bb760c0e1a825eea5d582a8f2d] V4L/DVB: IR/mceusb: less generic callback name and remove cruft
git bisect bad 7c294402d58e22bb760c0e1a825eea5d582a8f2d
# bad: [82ce67bf262b3f47ecb5a0ca31cace8ac72b7c98] V4L/DVB: staging/lirc: fix non-CONFIG_MODULES build horkage
git bisect bad 82ce67bf262b3f47ecb5a0ca31cace8ac72b7c98
next prev parent reply other threads:[~2011-02-12 17:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101207190753.GA21666@io.frii.com>
2011-01-10 2:14 ` DViCO FusionHDTV7 Dual Express I2C write failed Mark Zimmerman
2011-01-19 15:59 ` VDR User
2011-01-19 16:13 ` Devin Heitmueller
2011-01-19 17:22 ` VDR User
2011-01-19 17:39 ` Mark Zimmerman
2011-01-24 15:49 ` Mark Zimmerman
2011-01-24 15:57 ` Devin Heitmueller
2011-01-25 14:27 ` Mark Zimmerman
2011-01-19 19:01 ` Timothy D. Lenz
2011-01-17 23:12 ` Timothy D. Lenz
2011-02-12 15:29 ` [get-bisect results]: " Mark Zimmerman
2011-02-12 16:27 ` Andy Walls
2011-02-12 16:36 ` Mark Zimmerman
2011-02-12 16:46 ` Andy Walls
2011-02-12 17:03 ` Mark Zimmerman [this message]
2011-02-12 19:05 ` Mark Zimmerman
2011-02-12 20:48 ` Andy Walls
2011-02-13 14:47 ` [corrected get-bisect " Mark Zimmerman
2011-02-13 14:52 ` Devin Heitmueller
2011-02-13 20:26 ` Mark Zimmerman
2011-02-13 21:26 ` Andy Walls
2011-02-14 0:16 ` Andy Walls
2011-02-14 14:29 ` Devin Heitmueller
2011-02-14 0:37 ` Mark Zimmerman
2011-02-14 8:05 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212170305.GA30334@io.frii.com \
--to=markzimm@frii.com \
--cc=awalls@md.metrocast.net \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox