public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarod Wilson <jarod@redhat.com>
To: Stephen Wilson <wilsons@start.ca>
Cc: "Andy Walls" <awalls@md.metrocast.net>,
	"Mauro Carvalho Chehab" <mchehab@infradead.org>,
	"David Härdeman" <david@hardeman.nu>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] rc: do not enable remote controller adapters by default.
Date: Wed, 16 Feb 2011 10:20:26 -0500	[thread overview]
Message-ID: <20110216152026.GA17102@redhat.com> (raw)
In-Reply-To: <m3ei78j9s7.fsf@fibrous.localdomain>

On Wed, Feb 16, 2011 at 10:09:44AM -0500, Stephen Wilson wrote:
> Andy Walls <awalls@md.metrocast.net> writes:
> 
> > On Wed, 2011-02-16 at 01:16 -0500, Stephen Wilson wrote:
> >> Having the RC_CORE config default to INPUT is almost equivalent to
> >> saying "yes".  Default to "no" instead.
> >>
> >> Signed-off-by: Stephen Wilson <wilsons@start.ca>
> >
> > I don't particularly like this, if it discourages desktop distributions
> > from building RC_CORE.  The whole point of RC_CORE in kernel was to have
> > the remote controllers bundled with TV and DTV cards "just work" out of
> > the box for end users.  Also the very popular MCE USB receiver device,
> > shipped with Media Center PC setups, needs it too.
> 
> A similar argument can be made for any particular feature or device that
> just works when the functionality is enabled :)
> 
> > Why exactly do you need it set to "No"?
> 
> It is not a need.  I simply observed that after the IR_ to RC_ rename
> there was another set of drivers being built which I did not ask for.

So disable them. I think most people would rather have this support
enabled so that remotes Just Work if a DTV card or stand-alone IR receiver
is plugged in without having to hunt back through Kconfig options to
figure out why it doesn't...

> It struck me as odd that because basic keyboard/mouse support was
> enabled I also got support for DTV card remote controls.
> 
> I don't think there are any other driver subsystems enabling themselves
> based on something as generic as INPUT (as a dependency it is just fine,
> obviously).
> 
> Overall, it just seems like the wrong setting to me.  Is there another
> predicate available that makes a bit more sense for RC_CORE other than
> INPUT?  Something related to the TV or DTV cards perhaps?

No. As Andy said, there are stand-alone devices, such as the Windows Media
Center Ed. eHome Infrared Transceivers which are simply a usb device, no
direct relation to any TV devices. A fair number of systems these days are
also shipping with built-in CIR support by way of a sub-function on an LPC
SuperIO chip. Remotes can be used to control more than just changing
channels on a TV tuner card (think music player, video playback app
streaming content from somewhere on the network, etc).

-- 
Jarod Wilson
jarod@redhat.com


  reply	other threads:[~2011-02-16 16:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16  6:16 [PATCH] [media] rc: do not enable remote controller adapters by default Stephen Wilson
2011-02-16 13:16 ` Andy Walls
2011-02-16 15:09   ` Stephen Wilson
2011-02-16 15:20     ` Jarod Wilson [this message]
2011-02-16 17:13       ` Stephen Wilson
2011-02-16 17:25       ` VDR User
2011-02-16 17:43         ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216152026.GA17102@redhat.com \
    --to=jarod@redhat.com \
    --cc=awalls@md.metrocast.net \
    --cc=david@hardeman.nu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=wilsons@start.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox