From: Felipe Balbi <balbi@ti.com>
To: David Cohen <dacohen@gmail.com>
Cc: balbi@ti.com,
Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>,
Thomas Weber <weber@corscience.de>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-omap@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans Verkuil <hverkuil@xs4all.nl>, Tejun Heo <tj@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] video: omap24xxcam: Fix compilation
Date: Mon, 21 Feb 2011 09:36:40 +0200 [thread overview]
Message-ID: <20110221073640.GA3094@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <AANLkTik5dwNZrUxjgjKeAQOsp610d6y_TNGg1b5Vc5Zd@mail.gmail.com>
Hi,
On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote:
> > I have to disagree. The fundamental problem is the circular dependency
> > between those two files:
> >
> > sched.h uses wait_queue_head_t defined in wait.h
> > wait.h uses TASK_* defined in sched.h
> >
> > So, IMO the real fix would be clear out the circular dependency. Maybe
> > introducing <linux/task.h> to define those TASK_* symbols and include
> > that on sched.h and wait.h
> >
> > Just dig a quick and dirty to try it out and works like a charm
>
> We have 2 problems:
> - omap24xxcam compilation broken
> - circular dependency between sched.h and wait.h
>
> To fix the broken compilation we can do what the rest of the kernel is
> doing, which is to include sched.h.
> Then, the circular dependency is fixed by some different approach
> which would probably change *all* current usage of TASK_*.
considering that 1 is caused by 2 I would fix 2.
> IMO, there's no need to create a dependency between those issues.
There's no dependency between them, it's just that the root cause for
this problem is a circular dependency between wait.h and sched.h
--
balbi
next prev parent reply other threads:[~2011-02-21 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 8:49 [PATCH resend] video: omap24xxcam: Fix compilation Thomas Weber
2011-02-07 16:15 ` Randy Dunlap
2011-02-15 11:28 ` Sakari Ailus
2011-02-15 11:37 ` Felipe Balbi
2011-02-15 11:44 ` Sylwester Nawrocki
2011-02-15 11:47 ` Felipe Balbi
2011-02-15 11:49 ` Sakari Ailus
2011-02-15 11:50 ` Thomas Weber
2011-02-15 11:53 ` Felipe Balbi
2011-02-15 12:17 ` Sakari Ailus
2011-02-19 11:35 ` David Cohen
2011-02-19 15:00 ` Felipe Balbi
2011-02-19 16:04 ` David Cohen
2011-02-21 7:36 ` Felipe Balbi [this message]
2011-02-21 12:09 ` David Cohen
2011-02-21 12:21 ` Felipe Balbi
2011-02-24 23:36 ` David Cohen
2011-02-25 6:59 ` Thomas Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221073640.GA3094@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=dacohen@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@maxwell.research.nokia.com \
--cc=tj@kernel.org \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).