From: Alexey Dobriyan <adobriyan@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: balbi@ti.com, David Cohen <dacohen@gmail.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu,
linux-omap@vger.kernel.org, linux-media@vger.kernel.org,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH v2 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h
Date: Mon, 21 Feb 2011 21:21:20 +0200 [thread overview]
Message-ID: <20110221192046.GA6822@p183.telecom.by> (raw)
In-Reply-To: <1298307962.24121.27.camel@twins>
On Mon, Feb 21, 2011 at 06:06:02PM +0100, Peter Zijlstra wrote:
> 1) remove the inclusion of completion.h -- easy we can live with an
> incomplete type.
ACK
> 2) move the other wait_queue_head_t users (signal_struct sighand_struct)
> out of sched.h
>
> 3) ...
Compile test! :^)
> 4) profit!
>
> Just isolating the TASK_state bits isn't going to be enough, wait.h also
> wants wake_up goo and schedule*(), therefore either include sched.h from
> whatever .c file you're using wait.h bits or do the above cleanup.
Speaking of junk in sched.h, I'll send mm_types.h removal next merge window
and maybe cred.h.
next prev parent reply other threads:[~2011-02-21 19:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 14:38 [PATCH v2 0/1] Fix linux/wait.h header file David Cohen
2011-02-21 14:38 ` [PATCH v2 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h David Cohen
2011-02-21 15:54 ` Peter Zijlstra
2011-02-21 16:03 ` David Cohen
2011-02-21 16:20 ` Peter Zijlstra
2011-02-21 16:29 ` Felipe Balbi
2011-02-21 16:43 ` Peter Zijlstra
2011-02-21 16:54 ` Felipe Balbi
2011-02-21 17:06 ` Peter Zijlstra
2011-02-21 17:18 ` Felipe Balbi
2011-02-21 19:21 ` Alexey Dobriyan [this message]
2011-02-21 17:21 ` Oleg Nesterov
2011-02-21 17:27 ` Oleg Nesterov
2011-02-22 15:38 ` David Cohen
2011-02-21 16:33 ` [PATCH v2 0/1] Fix linux/wait.h header file Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221192046.GA6822@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=balbi@ti.com \
--cc=dacohen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox