From: Vasiliy Kulikov <segoon@openwall.com>
To: linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Manjunatha Halli <manjunatha_halli@ti.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org
Subject: [bug] radio: wl128x: sleep inside of spinlock
Date: Sat, 12 Mar 2011 21:08:09 +0300 [thread overview]
Message-ID: <20110312180809.GA17963@albatros> (raw)
Hi,
There is a copy_to_user() call inside of spin_lock_irqsave()/spin_unlock_irqrestore():
drivers/media/radio/wl128x/fmdrv_common.c:
/* Copies RDS data from internal buffer to user buffer */
u32 fmc_transfer_rds_from_internal_buff(struct fmdev *fmdev, struct file *file,
u8 __user *buf, size_t count)
{
...
spin_lock_irqsave(&fmdev->rds_buff_lock, flags);
...
if (copy_to_user(buf, &fmdev->rx.rds.buff[fmdev->rx.rds.rd_idx],
...
spin_unlock_irqrestore(&fmdev->rds_buff_lock, flags);
return ret;
}
--
Vasiliy
reply other threads:[~2011-03-12 18:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110312180809.GA17963@albatros \
--to=segoon@openwall.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manjunatha_halli@ti.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox