public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [bug] radio: wl128x: sleep inside of spinlock
@ 2011-03-12 18:08 Vasiliy Kulikov
  0 siblings, 0 replies; only message in thread
From: Vasiliy Kulikov @ 2011-03-12 18:08 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mauro Carvalho Chehab, Manjunatha Halli, Hans Verkuil,
	linux-media

Hi,

There is a copy_to_user() call inside of spin_lock_irqsave()/spin_unlock_irqrestore():

drivers/media/radio/wl128x/fmdrv_common.c:

    /* Copies RDS data from internal buffer to user buffer */
    u32 fmc_transfer_rds_from_internal_buff(struct fmdev *fmdev, struct file *file,
            u8 __user *buf, size_t count)
    {
        ...
        spin_lock_irqsave(&fmdev->rds_buff_lock, flags);
        ...
            if (copy_to_user(buf, &fmdev->rx.rds.buff[fmdev->rx.rds.rd_idx],
        ...
        spin_unlock_irqrestore(&fmdev->rds_buff_lock, flags);
        return ret;
    }

-- 
Vasiliy

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-03-12 18:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-12 18:08 [bug] radio: wl128x: sleep inside of spinlock Vasiliy Kulikov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox