From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21285 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757014Ab1CXWF0 (ORCPT ); Thu, 24 Mar 2011 18:05:26 -0400 Date: Thu, 24 Mar 2011 18:05:23 -0400 From: Jarod Wilson To: Dan Carpenter Cc: Dmitri Belimov , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] tm6000: fix vbuf may be used uninitialized Message-ID: <20110324220523.GB28094@redhat.com> References: <1300997220-4354-1-git-send-email-jarod@redhat.com> <20110324203108.GX2008@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110324203108.GX2008@bicker> List-ID: Sender: On Thu, Mar 24, 2011 at 11:31:08PM +0300, Dan Carpenter wrote: > On Thu, Mar 24, 2011 at 04:07:00PM -0400, Jarod Wilson wrote: > > Signed-off-by: Jarod Wilson > > Jarod, there is a lot of information missing from your change log... :/ Hrm, I'm building the media stack with all warnings fatal, so this was just a quick fix to silence the compiler warning, didn't really look into it at all. > > CC: devel@driverdev.osuosl.org > > --- > > drivers/staging/tm6000/tm6000-video.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c > > index c80a316..bfebedd 100644 > > --- a/drivers/staging/tm6000/tm6000-video.c > > +++ b/drivers/staging/tm6000/tm6000-video.c > > @@ -228,7 +228,7 @@ static int copy_streams(u8 *data, unsigned long len, > > unsigned long header = 0; > > int rc = 0; > > unsigned int cmd, cpysize, pktsize, size, field, block, line, pos = 0; > > - struct tm6000_buffer *vbuf; > > + struct tm6000_buffer *vbuf = NULL; > > char *voutp = NULL; > > unsigned int linewidth; > > > > This looks like a real bug versus just a GCC warning. It was introduced > in 8aff8ba95155df "[media] tm6000: add radio support to the driver". > I've added Dmitri to the CC list. Thanks much, will try to pay more attention next time. ;) -- Jarod Wilson jarod@redhat.com