From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: olivier.grenie@dibcom.fr, patrick.boettcher@dibcom.fr,
mchehab@redhat.com
Cc: linux-media@vger.kernel.org
Subject: Typo in dib0700_devices.c
Date: Sat, 2 Apr 2011 00:44:12 +0100 [thread overview]
Message-ID: <20110401234412.GB28823@gallifrey> (raw)
Hi,
sparse lead me to what looks like a typo in dib0700_devices.c:
drivers/media/dvb/dvb-usb/dib0700_devices.c:2160:18: warning: Initializer entry defined twice
drivers/media/dvb/dvb-usb/dib0700_devices.c:2165:18: also defined here
2160 .agc1_pt1 = 0,
.agc1_pt2 = 0,
.agc1_pt3 = 98,
.agc1_slope1 = 0,
.agc1_slope2 = 167,
2165 .agc1_pt1 = 98,
.agc2_pt2 = 255,
Note the line 2165 says .agc1_pt1 - I believe that should be
agc*2*_pt1 (without knowing anything at all about your hardware!)
The last thing that changed that was Olivier's patch
b4d6046e841955be9cc49164b03b91c9524f9c2e
which was just a tidy up, but it had:
- .agc1_pt1 = 98, // agc2_pt1
....
+ .agc1_pt1 = 98,
Note the mismatch of the comment.
(I haven't got this hardware to test on - but if you've been having
some weird AGC issues on that card it might explain it!)
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
reply other threads:[~2011-04-02 0:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110401234412.GB28823@gallifrey \
--to=linux@treblig.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=olivier.grenie@dibcom.fr \
--cc=patrick.boettcher@dibcom.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox