* vb2_plane 'mapped' signed bit field
@ 2011-04-03 0:18 Dr. David Alan Gilbert
2011-04-03 0:24 ` Dr. David Alan Gilbert
2011-04-03 15:42 ` Pawel Osciak
0 siblings, 2 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2011-04-03 0:18 UTC (permalink / raw)
To: p.osciak; +Cc: mchehab, linux-media
Hi Pawel,
'sparse' spotted that vb2_plane's mapped field is a signed
bitfield:
include/media/videobuf2-core.h:78:41 1 bit signed int
struct vb2_plane {
void *mem_priv;
int mapped:1;
};
that probably should be an unsigned int (I can see code that assigns
1 to it that just won't fit).
(Introduced by e23ccc0ad9258634e6d52cedf473b35dc34416c7 , spotted in
2.6.39-rc1 )
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: vb2_plane 'mapped' signed bit field
2011-04-03 0:18 vb2_plane 'mapped' signed bit field Dr. David Alan Gilbert
@ 2011-04-03 0:24 ` Dr. David Alan Gilbert
2011-04-03 15:42 ` Pawel Osciak
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2011-04-03 0:24 UTC (permalink / raw)
To: pawel; +Cc: mchehab, linux-media, zyprowski
(Originally sent to Pawel's Samsung address that bounced)
* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> Hi Pawel,
> 'sparse' spotted that vb2_plane's mapped field is a signed
> bitfield:
>
> include/media/videobuf2-core.h:78:41 1 bit signed int
>
> struct vb2_plane {
> void *mem_priv;
> int mapped:1;
> };
>
> that probably should be an unsigned int (I can see code that assigns
> 1 to it that just won't fit).
>
> (Introduced by e23ccc0ad9258634e6d52cedf473b35dc34416c7 , spotted in
> 2.6.39-rc1 )
>
> Dave
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ gro.gilbert @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: vb2_plane 'mapped' signed bit field
2011-04-03 0:18 vb2_plane 'mapped' signed bit field Dr. David Alan Gilbert
2011-04-03 0:24 ` Dr. David Alan Gilbert
@ 2011-04-03 15:42 ` Pawel Osciak
1 sibling, 0 replies; 3+ messages in thread
From: Pawel Osciak @ 2011-04-03 15:42 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: mchehab, linux-media
On Sat, Apr 2, 2011 at 17:18, Dr. David Alan Gilbert <linux@treblig.org> wrote:
> Hi Pawel,
> 'sparse' spotted that vb2_plane's mapped field is a signed
> bitfield:
>
> include/media/videobuf2-core.h:78:41 1 bit signed int
>
> struct vb2_plane {
> void *mem_priv;
> int mapped:1;
> };
>
> that probably should be an unsigned int (I can see code that assigns
> 1 to it that just won't fit).
Hi David,
Thanks for the report, will fix soon.
--
Best regards,
Pawel Osciak
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-03 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-03 0:18 vb2_plane 'mapped' signed bit field Dr. David Alan Gilbert
2011-04-03 0:24 ` Dr. David Alan Gilbert
2011-04-03 15:42 ` Pawel Osciak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox