From: Steffen Barszus <steffenbpunkt@googlemail.com>
To: Lutz Sammer <johns98@gmx.net>
Cc: linux-media@vger.kernel.org, liplianin@me.by, abraham.manu@gmail.com
Subject: Re: [PATCH] Fixes stb0899 not locking
Date: Mon, 18 Apr 2011 07:48:22 +0200 [thread overview]
Message-ID: <20110418074822.0d2174a2@grobi> (raw)
In-Reply-To: <4D99B357.50804@gmx.net>
On Mon, 04 Apr 2011 14:02:31 +0200
Lutz Sammer <johns98@gmx.net> wrote:
> Fixes stb0899 not locking.
> See http://www.spinics.net/lists/linux-media/msg30486.html ...
>
> When stb0899_check_data is entered, it could happen, that the data is
> already locked and the data search looped. stb0899_check_data fails
> to lock on a good frequency. stb0899_search_data uses an extrem big
> search step and fails to lock.
>
> The new code checks for lock before starting a new search.
> The first read ignores the loop bit, for the case that the loop bit is
> set during the search setup. I also added the msleep to reduce the
> traffic on the i2c bus.
>
Thanks Lutz for getting down to the problem :) !
Manu, Mauro,
Any comments ? Let's have that finally sorted.
I think its proven now that its a bug. We have a fix.
---
A few test result on 2.6.39-rc3 from vdr-portal(thx to jrie, hope its
ok for him). This is tuning a pre defined channel list until we have a
lock and then tune the next.
Astra_only.txt + Original
TOT: lok_errs =172, runs=1136 of sequ=1135, multi=56032, multi_max=931
real 101m40.777s
user 0m0.083s
sys 0m19.039s
Astra_only.txt + stb0899_not_locking_fix.diff
TOT: lok_errs =0, runs=1136 of sequ=1135, multi=289, multi_max=99
real 17m15.636s
user 0m0.007s
sys 0m9.445s
next prev parent reply other threads:[~2011-04-18 5:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 12:02 [PATCH] Fixes stb0899 not locking Lutz Sammer
2011-04-18 5:48 ` Steffen Barszus [this message]
2011-04-21 21:02 ` Steffen Barszus
-- strict thread matches above, loose matches on Subject: below --
2011-04-23 19:32 Issa Gorissen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418074822.0d2174a2@grobi \
--to=steffenbpunkt@googlemail.com \
--cc=abraham.manu@gmail.com \
--cc=johns98@gmx.net \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox