From: Jean-Francois Moine <moinejf@free.fr>
To: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG
Date: Thu, 26 May 2011 08:49:12 +0200 [thread overview]
Message-ID: <20110526084912.1ac3ac37@tele> (raw)
In-Reply-To: <1306359272-30792-1-git-send-email-jarod@redhat.com>
On Wed, 25 May 2011 17:34:32 -0400
Jarod Wilson <jarod@redhat.com> wrote:
> diff --git a/drivers/media/video/gspca/kinect.c b/drivers/media/video/gspca/kinect.c
> index 66671a4..26fc206 100644
> --- a/drivers/media/video/gspca/kinect.c
> +++ b/drivers/media/video/gspca/kinect.c
> @@ -34,7 +34,7 @@ MODULE_AUTHOR("Antonio Ospite <ospite@studenti.unina.it>");
> MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
> MODULE_LICENSE("GPL");
>
> -#ifdef DEBUG
> +#ifdef GSPCA_DEBUG
> int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
> D_USBI | D_USBO | D_V4L2;
> #endif
Hi Jarod,
Sorry, it is not the right fix. In fact, the variable gspca_debug must
not be defined in gspca subdrivers:
--- a/drivers/media/video/gspca/kinect.c
+++ b/drivers/media/video/gspca/kinect.c
@@ -34,11 +34,6 @@
MODULE_DESCRIPTION("GSPCA/Kinect Sensor Device USB Camera Driver");
MODULE_LICENSE("GPL");
-#ifdef DEBUG
-int gspca_debug = D_ERR | D_PROBE | D_CONF | D_STREAM | D_FRAM | D_PACK |
- D_USBI | D_USBO | D_V4L2;
-#endif
-
struct pkt_hdr {
uint8_t magic[2];
uint8_t pad;
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2011-05-26 6:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 6:43 build errors on kinect and rc-main - 2.6.38 Nicolas WILL
2011-05-25 7:01 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Nicolas WILL
2011-05-25 8:10 ` [PATCH] s5p-csis: Add missing dependency on PLAT_S5P Sylwester Nawrocki
2011-05-25 8:34 ` [PATCH v2] " Sylwester Nawrocki
2011-05-25 21:41 ` build errors on kinect and rc-main - 2.6.38 (mipi-csis not rc-main) Jarod Wilson
2011-05-25 22:02 ` Jarod Wilson
2011-05-25 22:07 ` Nicolas WILL
2011-05-25 21:34 ` [PATCH] [media] gspca/kinect: wrap gspca_debug with GSPCA_DEBUG Jarod Wilson
2011-05-26 6:49 ` Jean-Francois Moine [this message]
2011-05-26 7:47 ` Antonio Ospite
2011-05-26 13:48 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526084912.1ac3ac37@tele \
--to=moinejf@free.fr \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox