PCTV nanoStick T2 290e support - Thank you!

PCTV nanoStick T2 290e support - Thank you!

[Nicolas WILL]

Just installed mine for MythTV.

Works great on the first try!

Many, many thanks!

Nico

Re: PCTV nanoStick T2 290e support - Thank you!

[Antti Palosaari]

On 05/27/2011 12:25 AM, Nicolas WILL wrote:
> Just installed mine for MythTV.
>
> Works great on the first try!
>
> Many, many thanks!

Thank you for the feedback!

:)

It will get also remote controller support and I also changed LNA (low 
noise amplifier) behind module parameter. After those patches [1] are 
applied, in few day, you can enable LNA loading module manually:
modprobe em28xx_dvb options=1
,if needed.

> Nico

[1] http://git.linuxtv.org/anttip/media_tree.git

Antti
-- 
http://palosaari.fi/

Re: PCTV nanoStick T2 290e support - Thank you!

[Bjørn Mork]

Antti Palosaari <crope@iki.fi> writes:
> On 05/27/2011 12:25 AM, Nicolas WILL wrote:
>> Just installed mine for MythTV.
>>
>> Works great on the first try!
>>
>> Many, many thanks!
>
> Thank you for the feedback!

I'm a bit curious about this device.  It seems to only be marketed as a
DVB-T2 device in areas where that spec is used.  But looking at your
driver, it seems that the device also supports DVB-C.  Is that correct?



Bjørn

Re: PCTV nanoStick T2 290e support - Thank you!

[Rémi Denis-Courmont]

On Fri, 27 May 2011 13:36:37 +0200, Bjørn Mork <bjorn@mork.no> wrote:

> Antti Palosaari <crope@iki.fi> writes:

>> On 05/27/2011 12:25 AM, Nicolas WILL wrote:

>>> Just installed mine for MythTV.

>>>

>>> Works great on the first try!

>>>

>>> Many, many thanks!

>>

>> Thank you for the feedback!

> 

> I'm a bit curious about this device.  It seems to only be marketed as a

> DVB-T2 device in areas where that spec is used.  But looking at your

> driver, it seems that the device also supports DVB-C.  Is that correct?



At least, DVB-C worked for me.



-- 

Rémi Denis-Courmont

http://www.remlab.net/

RE: PCTV nanoStick T2 290e support - Thank you!

[Nicolas WILL]

> -----Original Message-----
> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> owner@vger.kernel.org] On Behalf Of Bjørn Mork
> Sent: 27 May 2011 12:37
> To: linux-media@vger.kernel.org
> Subject: Re: PCTV nanoStick T2 290e support - Thank you!
> 
> Antti Palosaari <crope@iki.fi> writes:
> > On 05/27/2011 12:25 AM, Nicolas WILL wrote:
> >> Just installed mine for MythTV.
> >>
> >> Works great on the first try!
> >>
> >> Many, many thanks!
> >
> > Thank you for the feedback!
> 
> I'm a bit curious about this device.  It seems to only be marketed as a
> DVB-T2 device in areas where that spec is used.  But looking at your
> driver, it seems that the device also supports DVB-C.  Is that correct?

[   12.921835] DVB: registering adapter 4 frontend 0 (Sony CXD2820R (DVB-T/T2))...
[   12.921904] DVB: registering adapter 4 frontend 1 (Sony CXD2820R (DVB-C))...

Nico

Re: PCTV nanoStick T2 290e support - Thank you!

[Bjørn Mork]

Rémi Denis-Courmont <remi@remlab.net> writes:
> On Fri, 27 May 2011 13:36:37 +0200, Bjørn Mork <bjorn@mork.no> wrote:
>
>> I'm a bit curious about this device.  It seems to only be marketed as a
>> DVB-T2 device in areas where that spec is used.  But looking at your
>> driver, it seems that the device also supports DVB-C.  Is that correct?
> 
> At least, DVB-C worked for me.

Thanks.  Then I've ordered one of these :-)


Bjørn

Re: PCTV nanoStick T2 290e support - Thank you!

[Steve Kerrison]

The demodulator chip supports T,T2 and C.

Here in the UK you're not really allowed to attach cable receivers that
aren't supplied by the cable company (Virgin Media). That and the fact
that it has no access module for obvious reasons, I guess PCTV Systems
didn't see the benefit in marketing the C functionality.

I don't actually know if the windows driver supports C mode, it would be
amusing if we deliver more functionality with the Linux driver :)

Regards,
-- 
Steve Kerrison MEng Hons.
http://www.stevekerrison.com/ 

On Fri, 2011-05-27 at 13:36 +0200, Bjørn Mork wrote:
> Antti Palosaari <crope@iki.fi> writes:
> > On 05/27/2011 12:25 AM, Nicolas WILL wrote:
> >> Just installed mine for MythTV.
> >>
> >> Works great on the first try!
> >>
> >> Many, many thanks!
> >
> > Thank you for the feedback!
> 
> I'm a bit curious about this device.  It seems to only be marketed as a
> DVB-T2 device in areas where that spec is used.  But looking at your
> driver, it seems that the device also supports DVB-C.  Is that correct?
> 
> 
> 
> Bjørn
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PCTV nanoStick T2 290e support - Thank you!

[Bjørn Mork]

Steve Kerrison <steve@stevekerrison.com> writes:

> The demodulator chip supports T,T2 and C.
>
> Here in the UK you're not really allowed to attach cable receivers that
> aren't supplied by the cable company (Virgin Media). That and the fact
> that it has no access module for obvious reasons, I guess PCTV Systems
> didn't see the benefit in marketing the C functionality.

Well, I found it a bit weird that they do announce DVB-T + DVB-C support
for the "PCTV QuatroStick nano" (which has the exact same form factor
and look, and therefore obviously no CA slot either):
http://www.pctvsystems.com/Products/ProductsEuropeAsia/Hybridproducts/PCTVQuatroSticknano/tabid/254/language/en-GB/Default.aspx

While the "PCTV nanoStick T2" is announced as only DVB-T2 + DVB-T:
http://www.pctvsystems.com/Products/ProductsEuropeAsia/Digitalproducts/PCTVnanoStickT2/tabid/248/language/en-GB/Default.aspx

That's why I asked, even though the driver clearly supports DVB-C.  But
you may be right that this is because the "nanoStick T2" currently is
targeted for the UK.

Around here, we've actually got some cable companies supporting TV sets
with integrated receivers.  Of course requiring their CAM.  They
probably still don't like the thought of PC based receivers, but there
is some hope...


> I don't actually know if the windows driver supports C mode, it would be
> amusing if we deliver more functionality with the Linux driver :)

I thought downloading the Windows driver would tell, but
a) I cannot seem to find the Windows driver for this device, and
b) this info isn't easily found in the drivers I looked at

So who knows?  It would certainly be amusing.


Bjørn

Re: PCTV nanoStick T2 290e support - Thank you!

[Steve Kerrison]

Hi Bjørn,

> I thought downloading the Windows driver would tell, but
> a) I cannot seem to find the Windows driver for this device, and
> b) this info isn't easily found in the drivers I looked at

The bundled CD has the drivers on it, but I think it's also in the
driver bundle on their site for their other empia based cards:

ftp://ftp.pctvsystems.com/TV/driver/PCTV%2070e%2080e%20100e%20320e%
20330e%20800e/PCTV%2070e%2080e%20100e%20320e%20330e%20800e%20880e.zip

Found via
http://www.pctvsystems.com/tabid/62/default.aspx/Downloads/Driver/tabid/123/language/en-GB/Default.aspx

I'm not sure how you'd tell, other than perhaps firing up VLC on Windows
and seeing if you can open it as a DVB-C device?

Regards,
-- 
Steve Kerrison MEng Hons.
http://www.stevekerrison.com/ 

On Fri, 2011-05-27 at 14:41 +0200, Bjørn Mork wrote:
> Steve Kerrison <steve@stevekerrison.com> writes:
> 
> > The demodulator chip supports T,T2 and C.
> >
> > Here in the UK you're not really allowed to attach cable receivers that
> > aren't supplied by the cable company (Virgin Media). That and the fact
> > that it has no access module for obvious reasons, I guess PCTV Systems
> > didn't see the benefit in marketing the C functionality.
> 
> Well, I found it a bit weird that they do announce DVB-T + DVB-C support
> for the "PCTV QuatroStick nano" (which has the exact same form factor
> and look, and therefore obviously no CA slot either):
> http://www.pctvsystems.com/Products/ProductsEuropeAsia/Hybridproducts/PCTVQuatroSticknano/tabid/254/language/en-GB/Default.aspx
> 
> While the "PCTV nanoStick T2" is announced as only DVB-T2 + DVB-T:
> http://www.pctvsystems.com/Products/ProductsEuropeAsia/Digitalproducts/PCTVnanoStickT2/tabid/248/language/en-GB/Default.aspx
> 
> That's why I asked, even though the driver clearly supports DVB-C.  But
> you may be right that this is because the "nanoStick T2" currently is
> targeted for the UK.
> 
> Around here, we've actually got some cable companies supporting TV sets
> with integrated receivers.  Of course requiring their CAM.  They
> probably still don't like the thought of PC based receivers, but there
> is some hope...
> 
> 
> > I don't actually know if the windows driver supports C mode, it would be
> > amusing if we deliver more functionality with the Linux driver :)
> 
> I thought downloading the Windows driver would tell, but
> a) I cannot seem to find the Windows driver for this device, and
> b) this info isn't easily found in the drivers I looked at
> 
> So who knows?  It would certainly be amusing.
> 
> 
> Bjørn
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: PCTV nanoStick T2 290e support - Thank you!

[Ondřej Caletka]

Hello,

I would like to join the line of thankers for this wonderful driver. I
am using it with experimental DVB-T2 broadcast in Prague, CZE to stream
whole T2 MUX to a campus network using DVBlast. It run for a month now,
and only outages was the outages of the experimental transmisson itself.

It works as well as another DVB-T/S card. Great job!

--
Ondrej Caletka

Re: PCTV nanoStick T2 290e support - Thank you!

[Rémi Denis-Courmont]

Le vendredi 27 mai 2011 01:58:22 Antti Palosaari, vous avez écrit :
> On 05/27/2011 12:25 AM, Nicolas WILL wrote:
> > Just installed mine for MythTV.
> > 
> > Works great on the first try!
> > 
> > Many, many thanks!
> 
> Thank you for the feedback!

By the way, what is the V4L2 device node supposed to be? I don't suppose the 
hardware supports analog nor hardware decoding!? Is it just a left over from 
the em28xx driver?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis

Re: PCTV nanoStick T2 290e support - Thank you!

[Antti Palosaari]

On 05/28/2011 04:04 PM, Rémi Denis-Courmont wrote:
> By the way, what is the V4L2 device node supposed to be? I don't suppose the
> hardware supports analog nor hardware decoding!? Is it just a left over from
> the em28xx driver?

Yes. Totally useless for digital only em287x series, em288x is digital + 
analog.

Device hangs if not rmmod drivers before unplug and in my understanding 
there is some suspicion it is analog audio. Devin may know more.

regards,
Antti

-- 
http://palosaari.fi/

Re: PCTV nanoStick T2 290e support - Thank you!

[Devin Heitmueller]

On Saturday, May 28, 2011, Antti Palosaari <crope@iki.fi> wrote:
> On 05/28/2011 04:04 PM, Rémi Denis-Courmont wrote:
>
> By the way, what is the V4L2 device node supposed to be? I don't suppose the
> hardware supports analog nor hardware decoding!? Is it just a left over from
> the em28xx driver?
>
>
> Yes. Totally useless for digital only em287x series, em288x is digital + analog.
>
> Device hangs if not rmmod drivers before unplug and in my understanding there is some suspicion it is analog audio. Devin may know more.

Indeed, just never got around to refactoring the driver a bit to not
create the video device node for em287x based devices.  I did do the
work though for the VBI and ALSA nodes.  It's actually a bit tricky
and there was a risk of a regression due to the GPIO setup, so I have
to test it with all the 287x devices before it can go in.

The rmmod node has nothing to do with the ALSA stuff.  It's a general
module dependency problem which Jarod Wilson volunteered to
investigate earlier in the week.

Devin

> regards,
> Antti
>
> --
> http://palosaari.fi/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Writing descriptive commit messages (was Re: PCTV nanoStick T2 290e support - Thank you!)

[Bjørn Mork]

Bjørn Mork <bjorn@mork.no> writes:
> Rémi Denis-Courmont <remi@remlab.net> writes:
>> On Fri, 27 May 2011 13:36:37 +0200, Bjørn Mork <bjorn@mork.no> wrote:
>>
>>> I'm a bit curious about this device.  It seems to only be marketed as a
>>> DVB-T2 device in areas where that spec is used.  But looking at your
>>> driver, it seems that the device also supports DVB-C.  Is that correct?
>> 
>> At least, DVB-C worked for me.
>
> Thanks.  Then I've ordered one of these :-)

Received and tested.

Being quite conservative wrt kernel updates, I did a quick-n-dirty
backport of the PCTV nanoStick T2 290e support to 2.6.32. I chose to
keep it as simple as possible, by ignoring as much as possible of the
unrelated changes to the em28xx driver since 2.6.32.  This was quite
educational.  

One surprising issue that others might want to be aware of, was that

commit ca3dfd6a6f8364c1d51e548adb4564702f1141e9
Author: Mauro Carvalho Chehab <mchehab@redhat.com>
Date:   Fri Sep 10 17:29:14 2010 -0300

    [media] em28xx: Add support for Leadership ISDB-T
    
    This device uses an em2874B + Sharp 921 One Seg frontend.
    
    Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>


actually has important side effects making it a *requirement* for 290e
support (and possibly other cards added after that commit).  The commit
message is completely misleading.  These changes to
drivers/media/video/em28xx/em28xx-cards.c are in no way described by it,
and do affect much more than the "Leadership ISDB-T" card:


@@ -2430,8 +2460,36 @@ void em28xx_card_setup(struct em28xx *dev)
                        dev->board.is_webcam = 0;
                else
                        dev->progressive = 1;
-       } else
-               em28xx_set_model(dev);
+       }
+
+       if (!dev->board.is_webcam) {
+               switch (dev->model) {
+               case EM2820_BOARD_UNKNOWN:
+               case EM2800_BOARD_UNKNOWN:
+               /*
+                * The K-WORLD DVB-T 310U is detected as an MSI Digivox AD.
+                *
+                * This occurs because they share identical USB vendor and
+                * product IDs.
+                *
+                * What we do here is look up the EEPROM hash of the K-WORLD
+                * and if it is found then we decide that we do not have
+                * a DIGIVOX and reset the device to the K-WORLD instead.
+                *
+                * This solution is only valid if they do not share eeprom
+                * hash identities which has not been determined as yet.
+                */
+               if (em28xx_hint_board(dev) < 0)
+                       em28xx_errdev("Board not discovered\n");
+               else {
+                       em28xx_set_model(dev);
+                       em28xx_pre_card_setup(dev);
+               }
+               break;
+               default:
+                       em28xx_set_model(dev);
+               }
+       }
 
        em28xx_info("Identified as %s (card=%d)\n",
                    dev->board.name, dev->model);
@@ -2749,8 +2807,8 @@ static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
        em28xx_pre_card_setup(dev);
 
        if (!dev->board.is_em2800) {
-               /* Sets I2C speed to 100 KHz */
-               retval = em28xx_write_reg(dev, EM28XX_R06_I2C_CLK, 0x40);
+               /* Resets I2C speed */
+               em28xx_write_reg(dev, EM28XX_R06_I2C_CLK, dev->board.i2c_speed);
                if (retval < 0) {
                        em28xx_errdev("%s: em28xx_write_regs_req failed!"
                                      " retval [%d]\n",




Could we please not do things like that?  That part should have been a
separate commit with a descriptive commit message.

Thanks.  




Bjørn