From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: mchehab@redhat.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
Hans Petter Selasky <hselasky@c2i.net>
Subject: Re: [PATCH] DVB: dvb-net, make the kconfig text helpful
Date: Thu, 16 Jun 2011 12:14:02 -0700 [thread overview]
Message-ID: <20110616121402.2e7441af.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1308251216-8194-1-git-send-email-jslaby@suse.cz>
On Thu, 16 Jun 2011 21:06:56 +0200 Jiri Slaby wrote:
> Telling the user they can disable an option if they want is not the
> much useful. Describe what it is good for instead.
>
> The text was derived from Mauro's email.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> Cc: Hans Petter Selasky <hselasky@c2i.net>
Yes, much better. Thanks.
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/media/Kconfig | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index dc61895..279e2b9 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -89,11 +89,13 @@ config DVB_NET
> default (NET && INET)
> depends on NET && INET
> help
> - The DVB network support in the DVB core can
> - optionally be disabled if this
> - option is set to N.
> + This option enables DVB Network Support which is a part of the DVB
> + standard. It is used, for example, by automatic firmware updates used
> + on Set-Top-Boxes. It can also be used to access the Internet via the
> + DVB card, if the network provider supports it.
>
> - If unsure say Y.
> + You may want to disable the network support on embedded devices. If
> + unsure say Y.
>
> config VIDEO_MEDIA
> tristate
> --
> 1.7.5.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-06-16 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 7:06 DVB_NET help message is useless Jiri Slaby
2011-06-16 8:05 ` Hans Petter Selasky
2011-06-16 10:38 ` Mauro Carvalho Chehab
2011-06-16 19:06 ` [PATCH] DVB: dvb-net, make the kconfig text helpful Jiri Slaby
2011-06-16 19:14 ` Randy Dunlap [this message]
2011-06-17 6:04 ` Hans Petter Selasky
2011-06-17 8:02 ` Jiri Slaby
2011-06-17 8:38 ` Hans Petter Selasky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616121402.2e7441af.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=hselasky@c2i.net \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox