From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-media@vger.kernel.org, USB list <linux-usb@vger.kernel.org>,
Andiry Xu <andiry.xu@amd.com>, Alex He <alex.he@amd.com>
Subject: Re: uvcvideo failure under xHCI
Date: Fri, 17 Jun 2011 10:18:39 +0200 [thread overview]
Message-ID: <201106171018.40285.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1106161619140.1697-100000@iolanthe.rowland.org>
On Thursday 16 June 2011 22:20:22 Alan Stern wrote:
> On Thu, 16 Jun 2011, Sarah Sharp wrote:
> > On Thu, Jun 16, 2011 at 03:39:11PM -0400, Alan Stern wrote:
> > > That's appropriate. But nobody should ever set an isochronous URB's
> > > status field to -EPROTO, no matter whether the device is connected or
> > > not and no matter whether the host controller is alive or not.
> >
> > But the individual frame status be set to -EPROTO, correct? That's what
> > Alex was told to do when an isochronous TD had a completion code of
> > "Incompatible Device Error".
>
> Right. -EPROTO is a perfectly reasonable code for a frame's status.
> But not for an isochronous URB's status. There's no reason for
> uvcvideo to test for it.
The uvcvideo driver tests for -EPROTO for interrupt URBs only. For isochronous
URBs it tests for -ENOENT, -ECONNRESET and -ESHUTDOWN.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2011-06-17 8:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 1:39 uvcvideo failure under xHCI Sarah Sharp
2011-06-16 2:59 ` Sarah Sharp
2011-06-16 8:07 ` Laurent Pinchart
2011-06-16 14:35 ` Alan Stern
2011-06-16 17:17 ` Sarah Sharp
2011-06-16 17:39 ` Alan Stern
2011-06-16 19:06 ` Sarah Sharp
2011-06-16 19:39 ` Alan Stern
2011-06-16 19:58 ` Sarah Sharp
2011-06-16 20:20 ` Alan Stern
2011-06-17 8:18 ` Laurent Pinchart [this message]
2011-06-17 16:46 ` Sarah Sharp
2011-06-17 17:01 ` Laurent Pinchart
2011-06-17 18:19 ` Sarah Sharp
2011-06-18 11:21 ` Laurent Pinchart
2011-06-16 9:22 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106171018.40285.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alex.he@amd.com \
--cc=andiry.xu@amd.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox