From: Ralf Baechle <ralf@linux-mips.org>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure
Date: Fri, 24 Jun 2011 13:09:06 +0100 [thread overview]
Message-ID: <20110624120906.GB6327@linux-mips.org> (raw)
In-Reply-To: <4E04767A.5020201@infradead.org>
On Fri, Jun 24, 2011 at 08:35:22AM -0300, Mauro Carvalho Chehab wrote:
> Em 24-06-2011 08:16, Ralf Baechle escreveu:
> > tristate "miroSOUND PCM20 radio"
> > depends on ISA && VIDEO_V4L2 && SND
> > select SND_ISA
> > select SND_MIRO
> >
> > So SND_ISA gets forced on even though the dependency on ISA_DMA_API is not
> > fulfilled. That's solved by adding the dependency on ISA_DMA_API to
> > RADIO_MIROPCM20.
>
> Another option would be to convert the two above selects into depends on.
Depends has the disadvantage that users may have to enable unobvious
options first before they are offered the one they are looking for and
that's what a "depends SND_ISA" would cause in this case.
Ralf
next prev parent reply other threads:[~2011-06-24 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 14:47 [PATCH] SOUND: Fix non-ISA_DMA_API build failure Ralf Baechle
2011-06-24 8:26 ` Takashi Iwai
2011-06-24 11:16 ` Ralf Baechle
2011-06-24 11:35 ` Mauro Carvalho Chehab
2011-06-24 12:09 ` Ralf Baechle [this message]
2011-06-24 12:22 ` Takashi Iwai
2011-06-24 13:08 ` Ralf Baechle
2011-06-24 13:14 ` Takashi Iwai
2011-06-24 13:19 ` Arnd Bergmann
2011-06-24 13:36 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624120906.GB6327@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mchehab@infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox