From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from moutng.kundenserver.de ([212.227.126.171]:59285 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753237Ab1FXNUK (ORCPT ); Fri, 24 Jun 2011 09:20:10 -0400 From: Arnd Bergmann To: Ralf Baechle Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure Date: Fri, 24 Jun 2011 15:19:44 +0200 Cc: Mauro Carvalho Chehab , Jaroslav Kysela , Takashi Iwai , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-mips@linux-mips.org References: <20110623144750.GA10180@linux-mips.org> In-Reply-To: <20110623144750.GA10180@linux-mips.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106241519.44425.arnd@arndb.de> List-ID: Sender: On Thursday 23 June 2011 16:47:50 Ralf Baechle wrote: > Fixed by adding an explicit dependency on ISA_DMA_API for all of the > config statment that either result in the direction inclusion of code that > calls the ISA DMA API or selects something which in turn would use the ISA > DMA API. > > The sole ISA sound driver that does not use the ISA DMA API is the Adlib > driver so replaced the dependency of SND_ISA on ISA_DMA_API and add it to > each of the drivers individually. Do we really care all that much about the Adlib driver on platforms without ISA_DMA_API? Right now all of sound/isa/ is hidden behind ISA_DMA_API and I think that's acceptable > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index e4c97fd..0aeed28 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -168,7 +168,7 @@ config RADIO_MAXIRADIO > > config RADIO_MIROPCM20 > tristate "miroSOUND PCM20 radio" > - depends on ISA && VIDEO_V4L2 && SND > + depends on ISA && ISA_DMA_API && VIDEO_V4L2 && SND > select SND_ISA > select SND_MIRO > ---help--- Then this hunk by itself would be enough to solve the compile errors, AFAICT. Arnd