From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from out5.smtp.messagingengine.com ([66.111.4.29]:50483 "EHLO out5.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658Ab1GHBVX (ORCPT ); Thu, 7 Jul 2011 21:21:23 -0400 Date: Thu, 7 Jul 2011 18:19:33 -0700 From: Greg KH To: Jarod Wilson Cc: Jarod Wilson , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH] [staging] lirc_serial: allocate irq at init time Message-ID: <20110708011933.GA3059@kroah.com> References: <1308252706-13879-1-git-send-email-jarod@redhat.com> <20110705172119.GA19358@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-ID: Sender: On Thu, Jul 07, 2011 at 08:31:28PM -0400, Jarod Wilson wrote: > On Tue, Jul 5, 2011 at 1:21 PM, Greg KH wrote: > > On Thu, Jun 16, 2011 at 03:31:46PM -0400, Jarod Wilson wrote: > >> There's really no good reason not to just grab the desired IRQ at driver > >> init time, instead of every time the lirc device node is accessed. This > >> also improves the speed and reliability with which a serial transmitter > >> can operate, as back-to-back transmission attempts (i.e., channel change > >> to a multi-digit channel) don't have to spend time acquiring and then > >> releasing the IRQ for every digit, sometimes multiple times, if lircd > >> has been told to use the min_repeat parameter. > >> > >> CC: devel@driverdev.osuosl.org > >> Signed-off-by: Jarod Wilson > >> --- > >>  drivers/staging/lirc/lirc_serial.c |   44 +++++++++++++++++------------------ > >>  1 files changed, 21 insertions(+), 23 deletions(-) > > > > This patch doesn't apply to the staging-next branch, care to respin it > > and resend it so I can apply it? > > This actually got merged into mainline a few days ago via the media tree. > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c4b0afee3c1730cf9b0f6ad21729928d23d3918e > > Do you want me to take a look at what's in staging-next and fix that > up to apply on top of the above? No, if it went in there, that's fine with me. greg k-h