From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from out3.smtp.messagingengine.com ([66.111.4.27]:37242 "EHLO
	out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752730Ab1HWVtj (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Tue, 23 Aug 2011 17:49:39 -0400
Date: Tue, 23 Aug 2011 14:44:21 -0700
From: Greg KH <greg@kroah.com>
To: "Leonid V. Fedorenchik" <leonidsbox@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	Palash Bandyopadhyay <Palash.Bandyopadhyay@conexant.com>,
	Ruslan Pisarev <ruslan@rpisarev.org.ua>,
	Ilya Gorskin <Revent82@gmail.com>,
	Joe Perches <joe@perches.com>, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2] Staging: cx25821: fix coding style issues
Message-ID: <20110823214421.GF3679@kroah.com>
References: <1312275798-9669-1-git-send-email-leonidsbox@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1312275798-9669-1-git-send-email-leonidsbox@gmail.com>
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On Tue, Aug 02, 2011 at 05:03:18PM +0800, Leonid V. Fedorenchik wrote:
> Fix too long lines in cx25821-audio.h
> Fix wrong brace placement in cx25821-cards.c, cx25821-core.c,
> and cx25821-i2c.c
> Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl.
> Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place.
> Delete file cx25821-gpio.h since it is not used.
> Get rid of typedef in cx25821.h.

I prefer to get patches in a "one patch per thing you did" format.

So, care to split this up into a number of smaller patches, all doing
the individual thing you list above?

Yes, it's going to be a bunch of small patches, but then they will be
"obviously" correct and trivial to review and apply.

thanks,

greg k-h