From: "Leonid V. Fedorenchik" <leonidsbox@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Palash Bandyopadhyay <Palash.Bandyopadhyay@conexant.com>,
Ruslan Pisarev <ruslan@rpisarev.org.ua>,
Ilya Gorskin <Revent82@gmail.com>, Joe Perches <joe@perches.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] Staging: cx25821: fix coding style issues
Date: Wed, 24 Aug 2011 11:14:59 +0800 [thread overview]
Message-ID: <20110824111459.7320e557@inspire> (raw)
In-Reply-To: <20110823214421.GF3679@kroah.com>
On Tue, 23 Aug 2011 14:44:21 -0700
Greg KH <greg@kroah.com> wrote:
> On Tue, Aug 02, 2011 at 05:03:18PM +0800, Leonid V. Fedorenchik wrote:
> > Fix too long lines in cx25821-audio.h
> > Fix wrong brace placement in cx25821-cards.c, cx25821-core.c,
> > and cx25821-i2c.c
> > Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl.
> > Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to the right place.
> > Delete file cx25821-gpio.h since it is not used.
> > Get rid of typedef in cx25821.h.
>
> I prefer to get patches in a "one patch per thing you did" format.
>
> So, care to split this up into a number of smaller patches, all doing
> the individual thing you list above?
>
> Yes, it's going to be a bunch of small patches, but then they will be
> "obviously" correct and trivial to review and apply.
>
> thanks,
>
> greg k-h
OK, no problem. I'll do this.
Leonid V. Fedorenchik
prev parent reply other threads:[~2011-08-24 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 9:03 [PATCH v2] Staging: cx25821: fix coding style issues Leonid V. Fedorenchik
2011-08-23 21:44 ` Greg KH
2011-08-24 3:14 ` Leonid V. Fedorenchik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824111459.7320e557@inspire \
--to=leonidsbox@gmail.com \
--cc=Palash.Bandyopadhyay@conexant.com \
--cc=Revent82@gmail.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=ruslan@rpisarev.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox