public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Luciano Coelho <coelho@ti.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	matti.j.aaltonen@nokia.com, johannes@sipsolutions.net,
	linux-kernel@vger.kernel.org, sameo@linux.intel.com,
	mchehab@infradead.org, linux-media@vger.kernel.org,
	linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES
Date: Mon, 5 Sep 2011 16:19:35 +0200	[thread overview]
Message-ID: <201109051619.35553.arnd@arndb.de> (raw)
In-Reply-To: <20110905144134.2c80c4b9@endymion.delvare>

On Monday 05 September 2011, Jean Delvare wrote:
> As said before, I'm not sure. Yes, it makes it easier to select misc
> device drivers from Kconfig files. But it also makes it impossible to
> deselect all misc device drivers at once.
> 
> I think that what we really need is the implementation in the Kconfig
> system of smart selects, i.e. whenever an entry is selected, everything
> it depends on gets selected as well. I don't know how feasible this is,
> but if it can be done then I'd prefer this to your proposal.
> 
> Meanwhile, I am not in favor of applying your patch. The benefit is
> relatively small IMHO (misc device drivers are rarely selected) and
> there is one significant drawback.

Before I made this patch, I started a different one that added about
a dozen 'select MISC_DEVICES' statements sprinkled all over the kernel
in order to silence the Kconfig warnings.

The problem is that whenever you select that option, the misc directory
suddenly becomes visible when it was disabled before, and things like
'oldconfig' will start asking about all other misc drivers as well.

I think it would simply be more consistent to have it enabled all
the time. Well, even better would be to move the bulk of the misc
drivers to a proper location sorted by their subsystems. A lot of them
should never have been merged in their current state IMHO.

> That being said, I'm not the one to decide, so if you can convince
> someone with more power (aka Andrew Morton)...

I think I should finally do what has been  talked about a few times and
formally become the maintainer of drivers/char and drivers/misc ;-)

The problem is that I'm not actually a good maintainer, but maybe it's
better to just have someone instead of falling back to Andrew or
some random subsystem maintainer to send any patches for drivers/misc.

> >  config AD525X_DPOT
> >       tristate "Analog Devices Digital Potentiometers"
> > @@ -344,6 +328,12 @@ config ISL29020
> >         This driver can also be built as a module.  If so, the module
> >         will be called isl29020.
> >  
> > +config SENSORS_LIS3LV02D
> > +     tristate
> > +     depends on INPUT
> > +     select INPUT_POLLDEV
> > +     default n
> > +
> 
> If you patch gets applied, then this one would better be moved to
> drivers/misc/lis3lv02d/Kconfig.

Ah, that's true.

	Arnd

  reply	other threads:[~2011-09-05 14:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 17:02 Kconfig unmet dependency with RADIO_WL1273 Luciano Coelho
2011-08-29 17:27 ` Randy Dunlap
2011-08-29 18:41   ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Luciano Coelho
2011-08-29 18:54     ` Grant Likely
2011-08-31 16:18     ` Jean Delvare
2011-08-31 16:49     ` Arnd Bergmann
2011-09-02 11:54       ` Luciano Coelho
2011-09-02 12:37       ` Jean Delvare
2011-09-02 14:43         ` [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES Arnd Bergmann
2011-09-05 12:41           ` Jean Delvare
2011-09-05 14:19             ` Arnd Bergmann [this message]
2011-09-05 14:27               ` Jean Delvare
2011-09-18 15:11               ` Randy Dunlap
2011-09-18 15:28                 ` Greg KH
2011-09-18 18:45                   ` Randy Dunlap
2011-09-19  8:47                     ` Arnd Bergmann
2011-09-19 13:07                       ` Greg KH
2011-09-19 15:14                         ` Arnd Bergmann
2011-09-02 14:43         ` [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT Arnd Bergmann
2011-09-05 13:09           ` Jean Delvare
2011-09-15 15:46           ` Samuel Ortiz
2011-09-02 15:49         ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Arnd Bergmann
2011-09-15 17:16     ` Grant Likely
2011-09-19 15:06       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109051619.35553.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=coelho@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=johannes@sipsolutions.net \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=matti.j.aaltonen@nokia.com \
    --cc=mchehab@infradead.org \
    --cc=rdunlap@xenotime.net \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox