From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: linux-media@vger.kernel.org, srinivasa.deevi@conexant.com,
Maxime Ripard <maxime.ripard@free-electrons.com>
Subject: Re: cx231xx: DMA problem on ARM
Date: Thu, 22 Sep 2011 16:45:08 +0200 [thread overview]
Message-ID: <20110922164508.395c2900@skate> (raw)
In-Reply-To: <CAGoCfiyFbHcZO-Rz2VFr249NprqvhQhcSPBLHRj_Txs9gimYqA@mail.gmail.com>
Hello,
Le Wed, 21 Sep 2011 08:04:52 -0400,
Devin Heitmueller <dheitmueller@kernellabs.com> a écrit :
> I ran into the same issue on em28xx in the past (which is what those
> parts of cx231xx are based on). Yes, just adding
> URB_NO_TRANSFER_DMA_MAP should result in it starting to work. Please
> try that out, and assuming it works feel free to submit a patch which
> can be included upstream.
So, we did try with URB_NO_TRANSFER_DMA_MAP, and now, we don't have the
BUG_ON() assertion anymore, but instead a large set of error messages:
[ 325.856231] cx231xx #0: setPowerMode::mode = 48, No Change req.
[ 325.858398] cx231xx #0: cx231xx_stop_stream():: ep_mask = 8
[ 325.860656] cx231xx #0: setPowerMode::mode = 48, No Change req.
[ 326.144073] cx231xx #0: cx231xx_stop_stream():: ep_mask = 8
[ 326.151245] cx231xx #0: cx231xx_initialize_stream_xfer: set video registers
[ 326.151763] cx231xx #0: cx231xx_start_stream():: ep_mask = 8
[ 396.907318] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 396.912048] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 396.977355] cx231xx #0: cx231xx_stop_stream():: ep_mask = 8
[ 396.987091] cx231xx #0: can't change interface 3 alt no. to 0 (err=-71)
[ 456.665252] cx231xx #0: setPowerMode::mode = 48, No Change req.
[ 456.675292] cx231xx #0: cannot change alt number to 3 (error=-71)
[ 456.714508] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.718811] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.719635] cx231xx #0: cx231xx_stop_stream():: ep_mask = 8
[ 456.729522] cx231xx #0: can't change interface 3 alt no. to 0 (err=-71)
[ 456.750427] cx231xx #0: setPowerMode::mode = 48, No Change req.
[ 456.756317] cx231xx #0: cannot change alt number to 3 (error=-71)
[ 456.778625] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.782745] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.786987] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.791381] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.795501] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.795532] cx231xx #0: cx231xx_set_decoder_video_input: adjust_ref_count :Failed to setAFE input mux - errCode [-71]!
[ 456.841491] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.845642] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.849792] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.854003] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.858123] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.862274] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.866394] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.870513] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.875030] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.879150] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.883239] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.887390] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.891632] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.895751] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.899993] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.904174] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.914825] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.919036] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.924499] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.936920] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.941131] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.946655] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.960144] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.968658] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.984344] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 456.999572] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.004577] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.015014] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.019561] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.029083] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.033264] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.039031] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.043121] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.047332] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.051513] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.059631] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.066467] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.071624] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.084686] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.088897] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.093658] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.097747] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.102050] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.106109] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.110229] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.114318] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.118469] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.122589] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.126708] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.130828] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.134979] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.139068] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.139099] cx231xx #0: video_mux : 0
[ 457.139099] cx231xx #0: do_mode_ctrl_overrides : 0xb000
[ 457.143218] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.143249] cx231xx #0: do_mode_ctrl_overrides NTSC
[ 457.147308] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.151519] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.156250] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.163269] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.169647] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.175415] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.179779] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.183898] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.183929] cx25840 4-0044: 720x480 is not a valid size!
[ 457.228576] cx231xx #0: cx231xx_stop_stream():: ep_mask = 8
[ 457.238769] cx231xx #0: cx231xx_initialize_stream_xfer: set video registers
[ 457.251892] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 457.256011] cx231xx #0: UsbInterface::sendCommand, failed with status --71
[ 519.125091] cx231xx #0: cx231xx_stop_stream():: ep_mask = 8
[ 519.137359] cx231xx #0: can't change interface 3 alt no. to 0 (err=-71)
The exact same device, connected to a x86 machine running the 3.0
kernel works just fine. We have diff'ed the cx231xx driver of both
kernels, and they are exactly the same, except for the
URB_NO_TRANSFER_DMA_MAP, which isn't strictly needed on x86.
Here is the patch that we apply on the cx231xx driver of the 3.0
kernel. The dont_use_port_3 part is a backport of a later kernel
version (commit 992299e84a4891275ea5924e30b66ce39a701e5e).
diff --git a/drivers/media/video/cx231xx/cx231xx-cards.c b/drivers/media/video/cx231xx/cx231xx-cards.c
index 2270381..7c7354d 100644
--- a/drivers/media/video/cx231xx/cx231xx-cards.c
+++ b/drivers/media/video/cx231xx/cx231xx-cards.c
@@ -387,6 +387,7 @@ struct cx231xx_board cx231xx_boards[] = {
.norm = V4L2_STD_NTSC,
.no_alt_vanc = 1,
.external_av = 1,
+ .dont_use_port_3 = 1,
.input = {{
.type = CX231XX_VMUX_COMPOSITE1,
.vmux = CX231XX_VIN_2_1,
diff --git a/drivers/media/video/cx231xx/cx231xx-core.c b/drivers/media/video/cx231xx/cx231xx-core.c
index abe500f..11761dd 100644
--- a/drivers/media/video/cx231xx/cx231xx-core.c
+++ b/drivers/media/video/cx231xx/cx231xx-core.c
@@ -1069,7 +1069,7 @@ int cx231xx_init_isoc(struct cx231xx *dev, int max_packets,
sb_size, cx231xx_isoc_irq_callback, dma_q, 1);
urb->number_of_packets = max_packets;
- urb->transfer_flags = URB_ISO_ASAP;
+ urb->transfer_flags = URB_ISO_ASAP | URB_NO_TRANSFER_DMA_MAP;
k = 0;
for (j = 0; j < max_packets; j++) {
@@ -1180,7 +1180,7 @@ int cx231xx_init_bulk(struct cx231xx *dev, int max_packets,
return -ENOMEM;
}
dev->video_mode.bulk_ctl.urb[i] = urb;
- urb->transfer_flags = 0;
+ urb->transfer_flags = URB_NO_TRANSFER_DMA_MAP;
dev->video_mode.bulk_ctl.transfer_buffer[i] =
usb_alloc_coherent(dev->udev, sb_size, GFP_KERNEL,
Do you have any idea of where to look at for the above problems?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-09-22 14:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 11:56 cx231xx: DMA problem on ARM Thomas Petazzoni
2011-09-21 12:04 ` Devin Heitmueller
2011-09-21 19:17 ` Thomas Petazzoni
2011-09-22 14:45 ` Thomas Petazzoni [this message]
2011-09-22 15:09 ` Devin Heitmueller
2011-09-22 15:29 ` Thomas Petazzoni
2011-09-23 12:04 ` Thomas Petazzoni
2011-09-23 12:26 ` Sri Deevi
2011-09-24 18:04 ` Thomas Petazzoni
2011-09-24 2:15 ` Mauro Carvalho Chehab
2011-09-26 8:13 ` Thomas Petazzoni
2011-09-26 17:32 ` Mauro Carvalho Chehab
2011-09-26 19:02 ` Laurent Pinchart
2011-09-26 19:59 ` Thomas Petazzoni
2011-09-26 20:03 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922164508.395c2900@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=srinivasa.deevi@conexant.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox