From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Josh Wu <josh.wu@atmel.com>,
nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org,
s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v3 2/2] at91: add Atmel ISI and ov2640 support on sam9m10/sam9g45 board.
Date: Sat, 24 Sep 2011 07:26:09 +0200 [thread overview]
Message-ID: <20110924052609.GI29998@game.jcrosoft.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1109220911500.11164@axis700.grange>
On 09:35 Thu 22 Sep , Guennadi Liakhovetski wrote:
> On Thu, 22 Sep 2011, Josh Wu wrote:
>
> > This patch
> > 1. add ISI_MCK parent setting code when add ISI device.
> > 2. add ov2640 support on board file.
> > 3. define isi_mck clock in sam9g45 chip file.
> >
> > Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > ---
> > arch/arm/mach-at91/at91sam9g45.c | 3 +
> > arch/arm/mach-at91/at91sam9g45_devices.c | 105 +++++++++++++++++++++++++++++-
> > arch/arm/mach-at91/board-sam9m10g45ek.c | 85 ++++++++++++++++++++++++-
> > arch/arm/mach-at91/include/mach/board.h | 3 +-
>
> Personally, I think, it would be better to separate this into two patches
> at least: one for at91 core and one for the specific board, but that's up
> to arch maintainers to decide.
>
> You also want to patch arch/arm/mach-at91/at91sam9263_devices.c, don't
> you?
agreed
Best Regards,
J.
next prev parent reply other threads:[~2011-09-24 6:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 4:11 [PATCH v3 1/2][media] Add code to enable/disable ISI_MCK clock Josh Wu
2011-09-22 4:11 ` [PATCH v3 2/2] at91: add Atmel ISI and ov2640 support on sam9m10/sam9g45 board Josh Wu
2011-09-22 7:35 ` Guennadi Liakhovetski
2011-09-24 5:26 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-09-26 9:22 ` Nicolas Ferre
2011-09-26 9:32 ` Guennadi Liakhovetski
2011-09-26 10:57 ` Wu, Josh
2011-09-26 11:21 ` Guennadi Liakhovetski
2011-09-30 9:05 ` Guennadi Liakhovetski
2011-09-30 9:14 ` [PATCH v3 1/2][media] Add code to enable/disable ISI_MCK clock Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110924052609.GI29998@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=g.liakhovetski@gmx.de \
--cc=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox