re: [media] V4L: soc-camera: make (almost) all client drivers re-usable outside of the framework

re: [media] V4L: soc-camera: make (almost) all client drivers re-usable outside of the framework

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

Hi Guennadi,

Gcc complains about 2f0babb7e432 "[media] V4L: soc-camera: make
(almost) all client drivers re-usable outside of the framework"

include/media/soc_camera.h: In function ‘soc_camera_i2c_to_vdev’:
include/media/soc_camera.h:257:34: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

--- a/include/media/soc_camera.h
+++ b/include/media/soc_camera.h
@@ -253,14 +253,14 @@ unsigned long soc_camera_apply_board_flags(struct soc_camera_link *icl,
 #include <linux/i2c.h>
  static inline struct video_device *soc_camera_i2c_to_vdev(const struct i2c_client *client)
   {
   -       struct soc_camera_device *icd = client->dev.platform_data;
   +       struct v4l2_subdev *sd = i2c_get_clientdata(client);
   +       struct soc_camera_device *icd = (struct soc_camera_device *)sd->grp_id;
           return icd ? icd->vdev : NULL;

sd->grp_id is a u32 so this doesn't work on 64 bit systems.

regards,
dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]