From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrew Vincer <Andrew.Vincer@redrat.co.uk>
Cc: "mchehab@infradead.org" <mchehab@infradead.org>,
"jarod@redhat.com" <jarod@redhat.com>,
"error27@gmail.com" <error27@gmail.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] rc: Fix input deadlock and transmit error in redrat3 driver
Date: Tue, 8 Nov 2011 20:11:23 +0300 [thread overview]
Message-ID: <20111108171122.GA4682@mwanda> (raw)
In-Reply-To: <DA69C24DC634074E9591C2B60BFDBC1C730E13@CP5-3512.fh.redrat.co.uk>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Tue, Nov 08, 2011 at 04:43:45PM +0000, Andrew Vincer wrote:
> Fixed submit urb logic so hardware doesn't hang trying to transmit
> signal data
>
> Removed unneeded enable/disable detector commands in
> redrat3_transmit_ir (the hardware does this anyway) and converted
> arguments to unsigned as per 5588dc2
>
This would be easier to review it you put the changes to enable and
disable into one patch and the changes so that we now measure the
buffer length in bytes instead of ints into a second patch.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-08 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 16:43 [PATCH 1/1] rc: Fix input deadlock and transmit error in redrat3 driver Andrew Vincer
2011-11-08 17:11 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108171122.GA4682@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Andrew.Vincer@redrat.co.uk \
--cc=error27@gmail.com \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox