From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Antti Palosaari <crope@iki.fi>,
linux-media <linux-media@vger.kernel.org>,
Michael Krufky <mkrufky@kernellabs.com>
Subject: Re: [RFC 1/2] dvb-core: add generic helper function for I2C register
Date: Thu, 10 Nov 2011 09:26:06 +0100 [thread overview]
Message-ID: <20111110092606.37fe3c45@endymion.delvare> (raw)
In-Reply-To: <4EBA6BC0.7080405@redhat.com>
On Wed, 09 Nov 2011 10:02:08 -0200, Mauro Carvalho Chehab wrote:
> Em 09-11-2011 08:37, Jean Delvare escreveu:
> > Speaking of struct i2c_client, I seem to remember that the dvb
> > subsystem doesn't use it much at the moment. This might be an issue if
> > you intend to get the generic code into i2c-core, as most helper
> > functions rely on a valid i2c_client structure by design.
>
> Yes, DVB uses the low level I2C ops. I don't see any reason why not
> changing it to use struct i2c_client (well, except that such change
> would require lots of changes and tests).
The "lots of changes and tests" part is indeed the problem. Furthermore
I clearly remember discussing this with Michael a couple years ago
(during the i2c device driver model rework) and telling him I would
never force DVB to make use of i2c_client if they did not want to. I
gave my word, taking it back now would be unfair. Well at least the new
i2c model would make it possible, this wasn't the case before, but this
is such a huge amount of work that I certainly don't want to push this
on anyone.
--
Jean Delvare
next prev parent reply other threads:[~2011-11-10 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 23:54 [RFC 1/2] dvb-core: add generic helper function for I2C register Antti Palosaari
2011-11-09 4:48 ` Michael Krufky
2011-11-09 9:56 ` Mauro Carvalho Chehab
2011-11-09 10:37 ` Jean Delvare
2011-11-09 11:00 ` Antti Palosaari
2011-11-09 12:02 ` Mauro Carvalho Chehab
2011-11-10 8:26 ` Jean Delvare [this message]
2011-11-09 15:51 ` Antti Palosaari
2011-11-09 10:41 ` Antti Palosaari
2011-11-09 10:52 ` Jean Delvare
2011-11-09 20:41 ` Malcolm Priestley
2011-11-14 13:52 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110092606.37fe3c45@endymion.delvare \
--to=khali@linux-fr.org \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mkrufky@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox