From: Ezequiel <elezegarcia@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-media@vger.kernel.org, moinejf@free.fr, ospite@studenti.unina.it
Subject: Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release
Date: Mon, 21 Nov 2011 20:02:17 -0300 [thread overview]
Message-ID: <20111121230217.GA2569@devel2> (raw)
In-Reply-To: <4EC8D069.1080204@redhat.com>
On Sun, Nov 20, 2011 at 11:03:21AM +0100, Hans de Goede wrote:
> NACK again! There is no reason to do this, it just makes
> the code more complicated without gaining anything. As already
> commented by Antonio Ospite your commit message lacks the why of
> this patch / the reason to do such a patch. The diffstat clearly
> shows it is adding code not removing / simplifying it and it
> so doing so without any good reasons!
>
Yes, it's true: I omit the the reason in the commit message.
The point of the patch was improving readability of the code.
But it was altogether wrong, as Jean-Francois patiently
explained to me in another thread.
Thanks to you too for the patience,
Ezequiel.
prev parent reply other threads:[~2011-11-21 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 21:46 [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release Ezequiel
2011-11-19 22:48 ` Antonio Ospite
2011-11-20 10:03 ` Hans de Goede
2011-11-21 23:02 ` Ezequiel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121230217.GA2569@devel2 \
--to=elezegarcia@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox