From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-68.nebula.fi ([83.145.220.68]:34807 "EHLO smtp-68.nebula.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878Ab1K1QEM (ORCPT ); Mon, 28 Nov 2011 11:04:12 -0500 Date: Mon, 28 Nov 2011 18:04:09 +0200 From: Sakari Ailus To: Joe Perches Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sakari Ailus Subject: Re: [trivial PATCH] omap24xxcam-dma: Fix logical test Message-ID: <20111128160409.GF29805@valkosipuli.localdomain> References: <1322422935.27199.3.camel@Joe-Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1322422935.27199.3.camel@Joe-Laptop> Sender: linux-media-owner@vger.kernel.org List-ID: On Sun, Nov 27, 2011 at 11:42:15AM -0800, Joe Perches wrote: > Likely misuse of & vs &&. > > Signed-off-by: Joe Perches Thanks, Joe! Acked-by: Sakari Ailus > --- > drivers/media/video/omap24xxcam-dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/omap24xxcam-dma.c b/drivers/media/video/omap24xxcam-dma.c > index 1d54b86..3ea38a8 100644 > --- a/drivers/media/video/omap24xxcam-dma.c > +++ b/drivers/media/video/omap24xxcam-dma.c > @@ -506,7 +506,7 @@ int omap24xxcam_sgdma_queue(struct omap24xxcam_sgdma *sgdma, > unsigned long flags; > struct sgdma_state *sg_state; > > - if ((sglen < 0) || ((sglen > 0) & !sglist)) > + if ((sglen < 0) || ((sglen > 0) && !sglist)) > return -EINVAL; > > spin_lock_irqsave(&sgdma->lock, flags); > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sakari Ailus e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk