From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v4 0/3] fbdev: Add FOURCC-based format configuration API
Date: Tue, 13 Dec 2011 12:46:26 +0100 [thread overview]
Message-ID: <201112131246.28062.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdVggt5wqKjBFjHYT4GH5M8rFUG_sOMB2aH5YrzEGH_VSA@mail.gmail.com>
Hi Geert,
On Tuesday 13 December 2011 11:47:02 Geert Uytterhoeven wrote:
> On Tue, Dec 13, 2011 at 01:40, Laurent Pinchart wrote:
> >> I think you also want to do something with red, green, blue, transp when
> >> entering FOURCC mode, at least setting them to zero or maybe even
> >> requiring that they are zero to enter FOURCC mode (as additional safety
> >> barrier).
> >
> > Agreed. The FOURCC mode documentation already requires those fields to be
> > set to 0 by applications.
> >
> > I'll enforce this in fb_set_var() if info->fix has the FB_CAP_FOURCC
> > capability flag set.
>
> So when info->fix has the FB_CAP_FOURCC capability flag set, you can no
> longer enter legacy mode?
No, when info->fix has the FB_CAP_FOURCC capability, you can no longer enter
legacy mode with grayscale > 1. You can still use grayscale = 0 and grayscale
= 1 for legacy mode. The grayscale field should not have values greater than 1
in legacy mode anyway, so that should be safe.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2011-12-13 11:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 10:26 [PATCH v4 0/3] fbdev: Add FOURCC-based format configuration API Laurent Pinchart
2011-11-29 10:26 ` [PATCH v4 1/3] " Laurent Pinchart
2011-11-29 10:26 ` [PATCH v4 2/3] v4l: Add V4L2_PIX_FMT_NV24 and V4L2_PIX_FMT_NV42 formats Laurent Pinchart
2011-11-29 17:19 ` Sylwester Nawrocki
2011-11-29 18:11 ` Laurent Pinchart
2011-11-29 10:26 ` [PATCH v4 3/3] fbdev: sh_mobile_lcdc: Support FOURCC-based format API Laurent Pinchart
2011-12-12 16:08 ` [PATCH v4 0/3] fbdev: Add FOURCC-based format configuration API Laurent Pinchart
2011-12-12 18:49 ` Florian Tobias Schandinat
2011-12-13 0:40 ` Laurent Pinchart
2011-12-13 10:47 ` Geert Uytterhoeven
2011-12-13 11:46 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112131246.28062.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=FlorianSchandinat@gmx.de \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox