From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] omap3isp: Support additional in-memory compressed bayer formats
Date: Wed, 28 Dec 2011 11:26:49 +0100 [thread overview]
Message-ID: <201112281126.49602.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <1325067657-32556-2-git-send-email-sakari.ailus@iki.fi>
Hi Sakari,
Thanks for the patch.
On Wednesday 28 December 2011 11:20:57 Sakari Ailus wrote:
> This also prevents accessing NULL pointer in csi2_try_format().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/video/omap3isp/ispvideo.c | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/omap3isp/ispvideo.c
> b/drivers/media/video/omap3isp/ispvideo.c index 0568234..3c984ae 100644
> --- a/drivers/media/video/omap3isp/ispvideo.c
> +++ b/drivers/media/video/omap3isp/ispvideo.c
> @@ -46,6 +46,10 @@
> * Helper functions
> */
>
> +/*
> + * NOTE: When adding new media bus codes, always remember to add
> + * corresponding in-memory formats to the table below!!!
> + */
> static struct isp_format_info formats[] = {
> { V4L2_MBUS_FMT_Y8_1X8, V4L2_MBUS_FMT_Y8_1X8,
> V4L2_MBUS_FMT_Y8_1X8, V4L2_MBUS_FMT_Y8_1X8,
> @@ -68,9 +72,18 @@ static struct isp_format_info formats[] = {
> { V4L2_MBUS_FMT_SRGGB8_1X8, V4L2_MBUS_FMT_SRGGB8_1X8,
> V4L2_MBUS_FMT_SRGGB8_1X8, V4L2_MBUS_FMT_SRGGB8_1X8,
> V4L2_PIX_FMT_SRGGB8, 8, },
> + { V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8, V4L2_MBUS_FMT_SBGGR10_DPCM8_1X8,
> + V4L2_MBUS_FMT_SBGGR10_1X10, 0,
> + V4L2_PIX_FMT_SBGGR10DPCM8, 8, },
> + { V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8, V4L2_MBUS_FMT_SGBRG10_DPCM8_1X8,
> + V4L2_MBUS_FMT_SGBRG10_1X10, 0,
> + V4L2_PIX_FMT_SGBRG10DPCM8, 8, },
> { V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8, V4L2_MBUS_FMT_SGRBG10_DPCM8_1X8,
> V4L2_MBUS_FMT_SGRBG10_1X10, 0,
> V4L2_PIX_FMT_SGRBG10DPCM8, 8, },
> + { V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8, V4L2_MBUS_FMT_SRGGB10_DPCM8_1X8,
> + V4L2_MBUS_FMT_SRGGB10_1X10, 0,
> + V4L2_PIX_FMT_SRGGB10DPCM8, 8, },
> { V4L2_MBUS_FMT_SBGGR10_1X10, V4L2_MBUS_FMT_SBGGR10_1X10,
> V4L2_MBUS_FMT_SBGGR10_1X10, V4L2_MBUS_FMT_SBGGR8_1X8,
> V4L2_PIX_FMT_SBGGR10, 10, },
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2011-12-28 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 10:20 [PATCH 0/2] Support additional DPCM compressed formats Sakari Ailus
2011-12-28 10:20 ` [PATCH 1/2] v4l: Add " Sakari Ailus
2011-12-28 10:25 ` Laurent Pinchart
2011-12-28 10:33 ` Sakari Ailus
2011-12-28 10:20 ` [PATCH 2/2] omap3isp: Support additional in-memory compressed bayer formats Sakari Ailus
2011-12-28 10:26 ` Laurent Pinchart [this message]
2011-12-28 13:01 ` [PATCH v2 1/1] v4l: Add DPCM compressed formats Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112281126.49602.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).