From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:56086 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753736Ab1L1N4B (ORCPT ); Wed, 28 Dec 2011 08:56:01 -0500 From: Laurent Pinchart To: "HeungJun, Kim" Subject: Re: [RFC PATCH 2/4] v4l: Add V4L2_CID_SCENEMODE menu control Date: Wed, 28 Dec 2011 14:56:04 +0100 Cc: linux-media@vger.kernel.org, mchehab@redhat.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi, s.nawrocki@samsung.com, kyungmin.park@samsung.com References: <1325053428-2626-1-git-send-email-riverful.kim@samsung.com> <1325053428-2626-3-git-send-email-riverful.kim@samsung.com> In-Reply-To: <1325053428-2626-3-git-send-email-riverful.kim@samsung.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201112281456.05515.laurent.pinchart@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org List-ID: Hi, On Wednesday 28 December 2011 07:23:46 HeungJun, Kim wrote: > It adds the new CID for setting Scenemode. This CID is provided as > menu type using the following items: > enum v4l2_scenemode { > V4L2_SCENEMODE_NONE = 0, > V4L2_SCENEMODE_NORMAL = 1, > V4L2_SCENEMODE_PORTRAIT = 2, > V4L2_SCENEMODE_LANDSCAPE = 3, > V4L2_SCENEMODE_SPORTS = 4, > V4L2_SCENEMODE_PARTY_INDOOR = 5, > V4L2_SCENEMODE_BEACH_SNOW = 6, > V4L2_SCENEMODE_SUNSET = 7, > V4L2_SCENEMODE_DAWN_DUSK = 8, > V4L2_SCENEMODE_FALL = 9, > V4L2_SCENEMODE_NIGHT = 10, > V4L2_SCENEMODE_AGAINST_LIGHT = 11, > V4L2_SCENEMODE_FIRE = 12, > V4L2_SCENEMODE_TEXT = 13, > V4L2_SCENEMODE_CANDLE = 14, > }; > > Signed-off-by: HeungJun, Kim > Signed-off-by: Kyungmin Park > --- > Documentation/DocBook/media/v4l/controls.xml | 88 > ++++++++++++++++++++++++++ drivers/media/video/v4l2-ctrls.c | > 21 ++++++ > include/linux/videodev2.h | 19 ++++++ > 3 files changed, 128 insertions(+), 0 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/controls.xml > b/Documentation/DocBook/media/v4l/controls.xml index 350c138..afe1845 > 100644 > --- a/Documentation/DocBook/media/v4l/controls.xml > +++ b/Documentation/DocBook/media/v4l/controls.xml > @@ -2879,6 +2879,94 @@ it one step further. This is a write-only > control. > > > + > + spanname="id">V4L2_CID_SCENEMODE  + > enum v4l2_scenemode > + This control sets > + the camera's scenemode, and it is provided by the type of > + the enum values. The "None" mode means the status > + when scenemode algorithm is not activated, like after booting time. > + On the other hand, the "Normal" mode means the scenemode algorithm > + is activated on the normal mode. What low-level parameters do the scene mode control ? How does it interact with the related controls ? > + > + > + > + > + > + V4L2_SCENEMODE_NONE  > + Scenemode None. > + > + > + V4L2_SCENEMODE_NORMAL  > + Scenemode Normal. > + > + > + V4L2_SCENEMODE_PORTRAIT  > + Scenemode Portrait. Could you please describe the scene modes in more details ? > + > + > + V4L2_SCENEMODE_LANDSCAPE  > + Scenemode Landscape. > + > + > + V4L2_SCENEMODE_SPORTS  > + Scenemode Sports. > + > + > + V4L2_SCENEMODE_PARTY_INDOOR  > + Scenemode Party Indoor. > + > + > + V4L2_SCENEMODE_BEACH_SNOW  > + Scenemode Beach Snow. > + > + > + V4L2_SCENEMODE_SUNSET  > + Scenemode Beach Snow. > + > + > + V4L2_SCENEMODE_DAWN_DUSK  > + Scenemode Dawn Dusk. > + > + > + V4L2_SCENEMODE_FALL  > + Scenemode Fall. > + > + > + V4L2_SCENEMODE_NIGHT  > + Scenemode Night. > + > + > + V4L2_SCENEMODE_AGAINST_LIGHT  > + Scenemode Against Light. > + > + > + V4L2_SCENEMODE_FIRE  > + Scenemode Fire. > + > + > + V4L2_SCENEMODE_TEXT  > + Scenemode Text. > + > + > + V4L2_SCENEMODE_CANDLE  > + Scenemode Candle. > + > + > + > + > + > + > + > + spanname="id">V4L2_CID_PRIVACY  + > boolean > + Prevent video from being acquired > +by the camera. When this control is set to TRUE (1), > no +image can be captured by the camera. Common means to enforce privacy > are +mechanical obturation of the sensor and firmware image processing, > but the +device is not restricted to these methods. Devices that implement > the privacy +control must support read access and may support write > access. + > > spanname="id">V4L2_CID_PRIVACY  > boolean -- Regards, Laurent Pinchart