From: Jean-Francois Moine <moinejf@free.fr>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver
Date: Fri, 30 Dec 2011 11:24:11 +0100 [thread overview]
Message-ID: <20111230112411.3089e281@tele> (raw)
In-Reply-To: <4EFD8494.4050506@redhat.com>
On Fri, 30 Dec 2011 10:29:56 +0100
Hans de Goede <hdegoede@redhat.com> wrote:
[snip]
> The following changes since commit 1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2:
>
> [media] tda10021: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200)
>
> are available in the git repository at:
> git://linuxtv.org/hgoede/gspca.git media-for_v3.3
[snip]
> Theodore Kilgore (1):
> gspca: add jl2005bcd sub driver
[snip]
I have noticed some problems with the patch 2346c78dff71b003f:
- there should be no change in gspca.h (addition of two empty lines)
- there is no documentation about the new pixel format 'JL20'
- in jl2005bcd.c, the macro 'err' is used instead of 'pr_err'
(there are also spaces at end of line, but this is less important..)
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2011-12-30 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 9:29 [GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver Hans de Goede
2011-12-30 10:24 ` Jean-Francois Moine [this message]
2011-12-30 10:56 ` Hans de Goede
2011-12-30 11:26 ` Jean-Francois Moine
2011-12-30 11:39 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111230112411.3089e281@tele \
--to=moinejf@free.fr \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox