From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-68.nebula.fi ([83.145.220.68]:38921 "EHLO smtp-68.nebula.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505Ab2AAMFe (ORCPT ); Sun, 1 Jan 2012 07:05:34 -0500 Date: Sun, 1 Jan 2012 14:05:28 +0200 From: Sakari Ailus To: Sylwester Nawrocki Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, t.stanislaws@samsung.com, dacohen@gmail.com, andriy.shevchenko@linux.intel.com, g.liakhovetski@gmx.de, hverkuil@xs4all.nl Subject: Re: [RFC 2/3] v4l: Image source control class Message-ID: <20120101120528.GG3677@valkosipuli.localdomain> References: <20111201143044.GI29805@valkosipuli.localdomain> <1323876147-18107-2-git-send-email-sakari.ailus@iki.fi> <4EFF1F6B.2090009@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EFF1F6B.2090009@gmail.com> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sylwester, Thanks for the review! On Sat, Dec 31, 2011 at 03:42:51PM +0100, Sylwester Nawrocki wrote: > On 12/14/2011 04:22 PM, Sakari Ailus wrote: > > Add image source control class. This control class is intended to contain > > low level controls which deal with control of the image capture process --- > > the A/D converter in image sensors, for example. > > > > Signed-off-by: Sakari Ailus > > --- > > Documentation/DocBook/media/v4l/controls.xml | 101 ++++++++++++++++++++ > > .../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 6 + > > drivers/media/video/v4l2-ctrls.c | 10 ++ > > include/linux/videodev2.h | 10 ++ > > 4 files changed, 127 insertions(+), 0 deletions(-) > > > > diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml > > index 3bc5ee8..69ede83 100644 > > --- a/Documentation/DocBook/media/v4l/controls.xml > > +++ b/Documentation/DocBook/media/v4l/controls.xml > > @@ -3356,6 +3356,107 @@ interface and may change in the future. > > > > > > > > + > > +
> > + Image Source Control Reference > > + > > + > > + Experimental > > + > > + This is an > + linkend="experimental">experimental interface and may > > + change in the future. > > + > > + > > + > > + The Image Source control class is intended for low-level > > + control of image source devices such as image sensors. The > > + devices feature an analogue to digital converter and a bus > > + transmitter to transmit the image data out of the device. > > + > > + > > + > > + Image Source Control IDs > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + > > + ID > > + Type > > + Description > > + > > + > > + > > + > > + > > + V4L2_CID_IMAGE_SOURCE_CLASS > > + class > > + > > + > > + The IMAGE_SOURCE class descriptor. > > + > > + > > + V4L2_CID_IMAGE_SOURCE_VBLANK > > + integer > > + > > + > > + Vertical blanking. The idle > > + preriod after every frame during which no image data is > > s/preriod/period > > > + produced. The unit of vertical blanking is a line. Every > > + line has length of the image width plus horizontal > > + blanking at the pixel clock specified by struct > > + v4l2_mbus_framefmt > + />. > > + > > + > > + V4L2_CID_IMAGE_SOURCE_HBLANK > > + integer > > + > > + > > + Horizontal blanking. The idle > > + preriod after every line of image data during which no > > s/preriod/period > > > + image data is produced. The unit of horizontal blanking is > > + pixels. > > + > > + > > + V4L2_CID_IMAGE_SOURCE_LINK_FREQ > > + integer menu > > + > > + > > + Image source's data bus frequency. > > + Together with the media bus pixel code, bus type (clock > > + cycles per sample), the data bus frequency defines the > > + pixel clock. The > > + frame rate can be calculated from the pixel clock, image > > + width and height and horizontal and vertical blanking. The > > + frame rate control is performed by selecting the desired > > + horizontal and vertical blanking. > > + > > + > > + > > + V4L2_CID_IMAGE_SOURCE_ANALOGUE_GAIN > > + integer > > + > > + > > + Analogue gain is gain affecting > > + all colour components in the pixel matrix. The gain > > + operation is performed in the analogue domain before A/D > > + conversion. > > + > > + > > + > > + > > + > > +
> > + > > +
> > + > > > > > >