From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)
Date: Tue, 3 Jan 2012 15:44:20 +0300 [thread overview]
Message-ID: <20120103124420.GA3626@mwanda> (raw)
In-Reply-To: <87ehw6sesk.fsf@rustcorp.com.au>
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
> diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> --- a/drivers/video/intelfb/intelfbdrv.c
> +++ b/drivers/video/intelfb/intelfbdrv.c
> @@ -230,16 +230,16 @@ MODULE_DESCRIPTION("Framebuffer driver f
> MODULE_LICENSE("Dual BSD/GPL");
> MODULE_DEVICE_TABLE(pci, intelfb_pci_table);
>
> -static int accel = 1;
> +static bool accel = 1;
> static int vram = 4;
> -static int hwcursor = 0;
> -static int mtrr = 1;
> -static int fixed = 0;
> -static int noinit = 0;
> -static int noregister = 0;
> -static int probeonly = 0;
> -static int idonly = 0;
> -static int bailearly = 0;
> +static bool hwcursor = 0;
> +static bool mtrr = 1;
> +static bool fixed = 0;
> +static bool noinit = 0;
> +static bool noregister = 0;
> +static bool probeonly = 0;
> +static bool idonly = 0;
> +static bool bailearly = 0;
bailearly should be an int here. It's part of some ugly debug code
where a value of 3 means bailout at point 3. Maybe we should just
remove it instead...
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next parent reply other threads:[~2012-01-03 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ehw6sesk.fsf@rustcorp.com.au>
2012-01-03 12:44 ` Dan Carpenter [this message]
2012-01-04 2:27 ` [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc) Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103124420.GA3626@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).