From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:54283 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113Ab2APOIU (ORCPT ); Mon, 16 Jan 2012 09:08:20 -0500 From: Laurent Pinchart To: Sakari Ailus Subject: Re: [PATCH 13/23] omap3isp: Add lane configuration to platform data Date: Mon, 16 Jan 2012 15:08:26 +0100 Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, teturtia@gmail.com, dacohen@gmail.com, snjw23@gmail.com, andriy.shevchenko@linux.intel.com, t.stanislaws@samsung.com, tuukkat76@gmail.com, k.debski@gmail.com, riverful@gmail.com References: <4F0DFE92.80102@iki.fi> <1326317220-15339-13-git-send-email-sakari.ailus@iki.fi> In-Reply-To: <1326317220-15339-13-git-send-email-sakari.ailus@iki.fi> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201201161508.26790.laurent.pinchart@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thanks for the patch. On Wednesday 11 January 2012 22:26:50 Sakari Ailus wrote: > Add lane configuration (order of clock and data lane) to platform data on > both CCP2 and CSI-2. > > Signed-off-by: Sakari Ailus > --- > drivers/media/video/omap3isp/ispcsiphy.h | 15 ++------------- > include/media/omap3isp.h | 25 +++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 13 deletions(-) > > diff --git a/drivers/media/video/omap3isp/ispcsiphy.h > b/drivers/media/video/omap3isp/ispcsiphy.h index 9596dc6..e93a661 100644 > --- a/drivers/media/video/omap3isp/ispcsiphy.h > +++ b/drivers/media/video/omap3isp/ispcsiphy.h > @@ -27,22 +27,11 @@ > #ifndef OMAP3_ISP_CSI_PHY_H > #define OMAP3_ISP_CSI_PHY_H > > +#include > + > struct isp_csi2_device; > struct regulator; > > -struct csiphy_lane { > - u8 pos; > - u8 pol; > -}; > - > -#define ISP_CSIPHY2_NUM_DATA_LANES 2 > -#define ISP_CSIPHY1_NUM_DATA_LANES 1 > - > -struct isp_csiphy_lanes_cfg { > - struct csiphy_lane data[ISP_CSIPHY2_NUM_DATA_LANES]; > - struct csiphy_lane clk; > -}; > - > struct isp_csiphy_dphy_cfg { > u8 ths_term; > u8 ths_settle; > diff --git a/include/media/omap3isp.h b/include/media/omap3isp.h > index 9c1a001..bc14099 100644 > --- a/include/media/omap3isp.h > +++ b/include/media/omap3isp.h > @@ -91,6 +91,29 @@ enum { > }; > > /** > + * struct isp_csiphy_lane: CCP2/CSI2 lane position and polarity > + * @pos: position of the lane > + * @pol: polarity of the lane > + */ > +struct isp_csiphy_lane { > + u8 pos; > + u8 pol; > +}; > + > +#define ISP_CSIPHY2_NUM_DATA_LANES 2 > +#define ISP_CSIPHY1_NUM_DATA_LANES 1 Any reason not to put CSIPHY1 first ? :-) With that modification, Acked-by: Laurent Pinchart > + > +/** > + * struct isp_csiphy_lanes_cfg - CCP2/CSI2 lane configuration > + * @data: Configuration of one or two data lanes > + * @clk: Clock lane configuration > + */ > +struct isp_csiphy_lanes_cfg { > + struct isp_csiphy_lane data[ISP_CSIPHY2_NUM_DATA_LANES]; > + struct isp_csiphy_lane clk; > +}; > + > +/** > * struct isp_ccp2_platform_data - CCP2 interface platform data > * @strobe_clk_pol: Strobe/clock polarity > * 0 - Non Inverted, 1 - Inverted > @@ -109,6 +132,7 @@ struct isp_ccp2_platform_data { > unsigned int ccp2_mode:1; > unsigned int phy_layer:1; > unsigned int vpclk_div:2; > + struct isp_csiphy_lanes_cfg lanecfg; > }; > > /** > @@ -119,6 +143,7 @@ struct isp_ccp2_platform_data { > struct isp_csi2_platform_data { > unsigned crc:1; > unsigned vpclk_div:2; > + struct isp_csiphy_lanes_cfg lanecfg; > }; > > struct isp_subdev_i2c_board_info { -- Regards, Laurent Pinchart