* [patch] [media] az6007: precedence bug in az6007_i2c_xfer()
@ 2012-01-25 8:01 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-01-25 8:01 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, kernel-janitors
The intent here was to test that the flag was clear but the '!' has
higher precedence than the '&'. I2C_M_RD is 0x1 so the current code is
equivalent to "&& (!sgs[i].flags) ..."
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/dvb/dvb-usb/az6007.c b/drivers/media/dvb/dvb-usb/az6007.c
index 02efd94..e693913 100644
--- a/drivers/media/dvb/dvb-usb/az6007.c
+++ b/drivers/media/dvb/dvb-usb/az6007.c
@@ -343,7 +343,7 @@ static int az6007_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
addr = msgs[i].addr << 1;
if (((i + 1) < num)
&& (msgs[i].len == 1)
- && (!msgs[i].flags & I2C_M_RD)
+ && (!(msgs[i].flags & I2C_M_RD))
&& (msgs[i + 1].flags & I2C_M_RD)
&& (msgs[i].addr == msgs[i + 1].addr)) {
/*
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-01-25 8:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-25 8:01 [patch] [media] az6007: precedence bug in az6007_i2c_xfer() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).