From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: mchehab@infradead.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, tomas.winkler@intel.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH 9/9] staging: easycap: Split easycap_delete() into several pieces
Date: Fri, 24 Feb 2012 22:38:43 +0300 [thread overview]
Message-ID: <20120224193842.GD3649@mwanda> (raw)
In-Reply-To: <1330097062-31663-9-git-send-email-elezegarcia@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
On Fri, Feb 24, 2012 at 12:24:22PM -0300, Ezequiel Garcia wrote:
> + /* Free video urbs */
> + free_video_urbs(peasycap);
These comments aren't redundant. Could you remove them in a later
patch?
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-24 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 15:24 [PATCH 1/9] staging: easycap: Split device struct alloc and retrieval code Ezequiel Garcia
2012-02-24 15:24 ` [PATCH 2/9] staging: easycap: Split buffer and video urb allocation Ezequiel Garcia
2012-02-24 15:24 ` [PATCH 3/9] staging: easycap: Push bInterfaceNumber saving to config_easycap() Ezequiel Garcia
2012-02-24 15:24 ` [PATCH 4/9] staging: easycap: Initialize 'ntsc' parameter before usage Ezequiel Garcia
2012-02-24 15:24 ` [PATCH 5/9] staging: easycap: Push video registration to easycap_register_video() Ezequiel Garcia
2012-02-24 18:39 ` Dan Carpenter
2012-02-24 18:58 ` Ezequiel García
2012-02-24 15:24 ` [PATCH 6/9] staging: easycap: Split audio buffer and urb allocation Ezequiel Garcia
2012-02-24 15:24 ` [PATCH 7/9] staging: easycap: Clean comment style in easycap_usb_disconnect() Ezequiel Garcia
2012-02-24 15:24 ` [PATCH 8/9] staging: easycap: Clean comment style in easycap_delete() Ezequiel Garcia
2012-02-24 15:24 ` [PATCH 9/9] staging: easycap: Split easycap_delete() into several pieces Ezequiel Garcia
2012-02-24 19:38 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120224193842.GD3649@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elezegarcia@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox