From: Dan Carpenter <dan.carpenter@oracle.com>
To: santosh nayak <santoshprasadnayak@gmail.com>
Cc: mchehab@infradead.org, dheitmueller@kernellabs.com,
hans.verkuil@cisco.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [media] dvb: negative value assigned to unsigned int in CDRXD().
Date: Wed, 7 Mar 2012 09:12:54 +0300 [thread overview]
Message-ID: <20120307061254.GQ22598@mwanda> (raw)
In-Reply-To: <1331091663-4790-1-git-send-email-santoshprasadnayak@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Wed, Mar 07, 2012 at 09:11:03AM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> In CDRXD(), Negative number is assigned to unsigned variable
> 'state->noise_cal.tdCal2.
>
> Members of 'SNoiseCal' should be 'signed short'.
>
In your changelogs could you please write something about how this
change will affect what the user sees. That way users know if it
fixes something they care about and they will apply your patch.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-07 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 3:41 [PATCH] [media] dvb: negative value assigned to unsigned int in CDRXD() santosh nayak
2012-03-07 6:12 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307061254.GQ22598@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dheitmueller@kernellabs.com \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox