From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-68.nebula.fi ([83.145.220.68]:53779 "EHLO smtp-68.nebula.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756050Ab2CGSLV (ORCPT ); Wed, 7 Mar 2012 13:11:21 -0500 Date: Wed, 7 Mar 2012 20:11:16 +0200 From: Sakari Ailus To: Michael Jones Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, dacohen@gmail.com, snjw23@gmail.com, andriy.shevchenko@linux.intel.com, t.stanislaws@samsung.com, tuukkat76@gmail.com, k.debski@samsung.com, riverful@gmail.com, hverkuil@xs4all.nl, teturtia@gmail.com, pradeep.sawlani@gmail.com Subject: Re: [PATCH v5 09/35] v4l: Add subdev selections documentation Message-ID: <20120307181116.GH1476@valkosipuli.localdomain> References: <20120306163239.GN1075@valkosipuli.localdomain> <1331051596-8261-9-git-send-email-sakari.ailus@iki.fi> <4F572216.50307@matrix-vision.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F572216.50307@matrix-vision.de> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Michael, Thanks for the comments. On Wed, Mar 07, 2012 at 09:53:42AM +0100, Michael Jones wrote: > Hi Sakari, > > Hopefully it's not too late to make a few minor suggestions. > > On 03/06/2012 05:32 PM, Sakari Ailus wrote: > >Add documentation for V4L2 subdev selection API. This changes also > >experimental V4L2 subdev API so that scaling now works through selection API > >only. > > > >Signed-off-by: Sakari Ailus > [snip] > >+ > >+On sink pads, cropping is applied relatively to the > > s/relatively/relative/ > > >+ current pad format. The pad format represents the image size as > >+ received by the sub-device from the previous block in the > >+ pipeline, and the crop rectangle represents the sub-image that > >+ will be transmitted further inside the sub-device for > >+ processing. > [snip] > >+On source pads, cropping is similar to sink pads, with the > >+ exception that the source size from which the cropping is > >+ performed, is the COMPOSE rectangle on the sink pad. In both > >+ sink and source pads, the crop rectangle must be entirely > >+ containted inside the source image size for the crop > > s/containted/contained/ > > >+ operation. > >+ > >+The drivers should always use the closest possible > >+ rectangle the user requests on all selection targets, unless > >+ specificly told otherwise. > > s/specificly/specifically/ > > >+V4L2_SUBDEV_SEL_FLAG_SIZE_GE and > >+V4L2_SUBDEV_SEL_FLAG_SIZE_LE flags may be > >+ used to round the image size either up or down. >+ linkend="v4l2-subdev-selection-flags"> > >+ > > [snip] > > >+V4L2_SUBDEV_SEL_FLAG_KEEP_CONFIG flag. This > >+ flag causes that no propagation of the changes are allowed in > >+ any circumstances. This may also cause the accessed rectangle to > > "This flag causes that" sounds ungrammatical. I suggest: "This flag > causes no propagation of the changes to be allowed under any > circumstances." Applied all of them. Cheers, -- Sakari Ailus e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk