From: "Michael Büsch" <m@bues.ch>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org, "Daniel Glöckner" <daniel-gl@gmx.net>
Subject: Re: [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 => TerraTec Cinergy T Stick [0ccd:0093]
Date: Sun, 1 Apr 2012 18:32:20 +0200 [thread overview]
Message-ID: <20120401183220.3e411278@milhouse> (raw)
In-Reply-To: <4F788045.40208@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
On Sun, 01 Apr 2012 19:20:21 +0300
Antti Palosaari <crope@iki.fi> wrote:
> On 01.04.2012 19:15, Michael Büsch wrote:
> > On Sun, 1 Apr 2012 15:11:53 +0200
> > Michael Büsch<m@bues.ch> wrote:
> >
> >> [ 3101.940765] i2c i2c-8: Failed to read VCO calibration value (got 20)
> >
> > Ok, it turns out that it doesn't fail all the time, but only sporadically.
> > So increasing the number of retries fixes (or at least works around) it.
>
> OK, feel free to add ~3 retries inside af9035_ctrl_msg() i think.
Well I didn't retry at that level, but at the fc0011 driver level.
It does already retry once in fc0011 (with complete tuner reset).
I increased it to 6 times (3 was not enough).
I think we can't retry at af9035_ctrl_msg() level, because the
actual i2c/usb transfer does not fail. The received packet checksum even
is ok (although we currently don't check it. I'll send a patch for that later).
> You didn't mention if error is coming from af9035 firmware or from USB
> stack. Just for the interest...
I don't know how much the firmware is involved in this, but _maybe_ this
glitch is caused by it.
--
Greetings, Michael.
PGP encryption is encouraged / 908D8B0E
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-01 16:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 12:33 [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 => TerraTec Cinergy T Stick [0ccd:0093] Antti Palosaari
2012-03-30 21:45 ` Michael Büsch
2012-03-30 22:00 ` Antti Palosaari
2012-03-30 22:14 ` Michael Büsch
2012-03-31 14:04 ` Michael Büsch
2012-03-31 14:28 ` Antti Palosaari
2012-03-31 16:29 ` Michael Büsch
2012-03-31 16:34 ` Antti Palosaari
2012-03-31 16:48 ` Antti Palosaari
2012-03-31 16:52 ` Michael Büsch
2012-04-01 4:51 ` Antti Palosaari
2012-04-01 8:33 ` Michael Büsch
2012-04-01 12:19 ` Michael Büsch
2012-04-01 12:29 ` Antti Palosaari
2012-04-01 13:11 ` Michael Büsch
2012-04-01 13:19 ` Antti Palosaari
2012-04-01 14:42 ` Hans-Frieder Vogt
2012-04-01 14:56 ` Michael Büsch
2012-04-01 16:24 ` Hans-Frieder Vogt
2012-04-01 16:36 ` Michael Büsch
2012-04-01 16:15 ` Michael Büsch
2012-04-01 16:20 ` Antti Palosaari
2012-04-01 16:32 ` Michael Büsch [this message]
2012-04-01 16:39 ` Antti Palosaari
2012-04-01 16:44 ` Michael Büsch
2012-04-01 9:56 ` Gianluca Gennari
2012-04-01 10:27 ` Hans-Frieder Vogt
2012-04-01 12:31 ` Antti Palosaari
2012-04-01 14:31 ` Hans-Frieder Vogt
2012-04-01 15:00 ` Antti Palosaari
2012-04-01 15:04 ` Hans-Frieder Vogt
2012-04-01 12:53 ` Antti Palosaari
2012-04-01 17:15 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 support for AverTV A867R (mxl5007t tuner) Hans-Frieder Vogt
2012-04-01 17:24 ` Antti Palosaari
2012-04-01 18:11 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 i2c read fix Hans-Frieder Vogt
2012-04-01 18:16 ` Antti Palosaari
2012-04-01 21:07 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 support for AverTV A867R (mxl5007t), version 2 Hans-Frieder Vogt
2012-04-01 21:19 ` [PATCH] AF9033 read_ber and read_ucblocks implementation Hans-Frieder Vogt
2012-04-01 21:56 ` Antti Palosaari
2012-04-01 22:11 ` Antti Palosaari
2012-04-01 21:32 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 support for AverTV A867R (mxl5007t), version 2 Antti Palosaari
2012-04-02 17:02 ` Hans-Frieder Vogt
2012-03-31 16:49 ` [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 => TerraTec Cinergy T Stick [0ccd:0093] Michael Büsch
2012-04-06 11:11 ` Antti Palosaari
2012-05-07 18:44 ` [GIT PULL FOR 3.5] AF9035/AF9033 Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120401183220.3e411278@milhouse \
--to=m@bues.ch \
--cc=crope@iki.fi \
--cc=daniel-gl@gmx.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox