From: "Michael Büsch" <m@bues.ch>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Add fc0011 tuner driver
Date: Mon, 2 Apr 2012 19:20:11 +0200 [thread overview]
Message-ID: <20120402192011.4edc82ff@milhouse> (raw)
In-Reply-To: <4F79DA52.2050907@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]
On Mon, 02 Apr 2012 19:56:50 +0300
Antti Palosaari <crope@iki.fi> wrote:
> On 02.04.2012 19:14, Michael Büsch wrote:
> > This adds support for the Fitipower fc0011 DVB-t tuner.
> >
> > Signed-off-by: Michael Buesch<m@bues.ch>
>
> Applied, thanks!
> http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental
>
> I looked it through quickly, no big issues. Anyhow, when I ran
> checkpatch.pl and it complains rather much. All Kernel developers must
> use checkpatch.pl before sent patches and fix findings if possible,
> errors must be fixed and warnings too if there is no good reason to
> leave as it is.
Well, I _did_ run it on the patch.
There is no error. Only (IMO bogus) warnings. Most of them
are about the 80 char limit. Which isn't really a hard limit. And those lines
only exceed the 80 char limit by a few chars (one, two or such). Splitting
those line serves no readability purpose. In fact, it just worsens it.
> And one note about tuner driver, my AF9035 + FC0011 device founds only 1
> mux of 4. Looks like some performance issues still to resolve.
I have no idea what this means.
So I have no remote idea of what could possibly be wrong here.
Is this a bug on af903x or the tuner driver?
--
Greetings, Michael.
PGP encryption is encouraged / 908D8B0E
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-02 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:14 [PATCH] Add fc0011 tuner driver Michael Büsch
2012-04-02 16:56 ` Antti Palosaari
2012-04-02 17:20 ` Michael Büsch [this message]
2012-04-02 17:40 ` Antti Palosaari
2012-04-02 17:51 ` Michael Büsch
2012-04-02 21:52 ` Antti Palosaari
2012-04-03 6:36 ` Michael Büsch
2012-05-07 19:02 ` Antti Palosaari
2012-05-07 21:00 ` Michael Büsch
2012-05-07 21:13 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402192011.4edc82ff@milhouse \
--to=m@bues.ch \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).