From: "Michael Büsch" <m@bues.ch>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] af9035: Add fc0011 tuner support
Date: Mon, 2 Apr 2012 19:24:10 +0200 [thread overview]
Message-ID: <20120402192410.1dd6cbc1@milhouse> (raw)
In-Reply-To: <4F79DBCC.6070803@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
On Mon, 02 Apr 2012 20:03:08 +0300
Antti Palosaari <crope@iki.fi> wrote:
> On 02.04.2012 19:18, Michael Büsch wrote:
> > This adds Fitipower fc0011 tuner support to the af9035 driver.
> >
> > Signed-off-by: Michael Buesch<m@bues.ch>
>
> Applied, thanks!
> http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/af9035_experimental
>
> And same checkpatch.pl issue here.
> You can ran checkpatch like that:
> git diff | ./scripts/checkpatch.pl -
> git diff --cached | ./scripts/checkpatch.pl -
> ./scripts/checkpatch.pl --file drivers/media/dvb/dvb-usb/af9035.c
>
> For that driver it complains you are using wrong sleep (msleep(10)).
> Correct sleep for that case is something like usleep_range(10000,
> 100000); which means as sleep at least 10ms but it does not matter if
> you sleep even 100ms. The wider range the better chance for Kernel to
> optimize power saving. There was usleep_range() already used inside that
> module.
Ok, the sleep warning is the only remotely sane checkpatch warning for these
patches. So I will send a separate patch to convert those sleeps.
--
Greetings, Michael.
PGP encryption is encouraged / 908D8B0E
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-02 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:18 [PATCH] af9035: Add fc0011 tuner support Michael Büsch
2012-04-02 17:03 ` Antti Palosaari
2012-04-02 17:24 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402192410.1dd6cbc1@milhouse \
--to=m@bues.ch \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).