Re: [PATCH] Add fc0011 tuner driver

["Michael Büsch" <m@bues.ch>]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On Mon, 02 Apr 2012 20:40:45 +0300
Antti Palosaari <crope@iki.fi> wrote:

> hmmmm, I think Mauro will at least complain when I ask he to PULL that 
> master. Personally I would like to see line len something more than 80 
> chars, but as checkpatch.pl complains it I have shortened lines despite 
> very few cases.

I'm not a friend of long lines. In fact, I'm developing on a Netbook
with split screen. So long lines will absolutely kill readability for me.
But there is "long" as in 90 or 100 chars and there is "long" as in
"uh let's stretch the 80 chars limit by a few chars, so that it's more readable".

I already worked on code from other kernel subsystems for quite some time
and the 80 char limit never was a hard limit there. For good reasons.

That said, iff the 80 char limit _is_ a hard limit for the DVB subsystem,
I'll honor it. I just think it would worsen the code.

> Likely tuner driver, or demod driver. But as demod tuner initialization 
> tables are likely correct I suspect it is tuner issue at first hand. And 
> secondly my other hardware with TUA9001 performs very well, better than 
> old AF9015 sticks.

Well the fc0011 tuner driver still works worse on this af9035 driver
than on Hans' driver. I have absolutely no idea why this is the case.
I'm almost certain that it is not a timing issue of some sort. I tried
a zillion of delays and such.

-- 
Greetings, Michael.

PGP encryption is encouraged / 908D8B0E

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]