From: "Michael Büsch" <m@bues.ch>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org, Hans-Frieder Vogt <hfvogt@gmx.net>,
Gianluca Gennari <gennarone@gmail.com>
Subject: Re: [PATCH] af9035: fix and enhance I2C adapter
Date: Tue, 3 Apr 2012 10:43:02 +0200 [thread overview]
Message-ID: <20120403104302.16346945@milhouse> (raw)
In-Reply-To: <1333409555-679-1-git-send-email-crope@iki.fi>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Tue, 3 Apr 2012 02:32:35 +0300
Antti Palosaari <crope@iki.fi> wrote:
> There was a bug I2C adapter writes and reads one byte too much.
> As the most I2C clients has auto-increment register addressing
> this leads next register from the target register overwritten by
> garbage data.
>
> As a change remove whole register address byte usage and write
> data directly to the I2C bus without saying what are register
> address bytes to firmware.
>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> Cc: Michael Buesch <m@bues.ch>
> Cc: Hans-Frieder Vogt <hfvogt@gmx.net>
> Cc: Gianluca Gennari <gennarone@gmail.com>
I can confirm that this fixes the issue. Thanks!
Tested-by: Michael Buesch <m@bues.ch>
--
Greetings, Michael.
PGP encryption is encouraged / 908D8B0E
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-03 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 23:32 [PATCH] af9035: fix and enhance I2C adapter Antti Palosaari
2012-04-03 8:43 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403104302.16346945@milhouse \
--to=m@bues.ch \
--cc=crope@iki.fi \
--cc=gennarone@gmail.com \
--cc=hfvogt@gmx.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).