From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
To: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Various fixes, hacks and patches for Mantis CA support.
Date: Wed, 18 Apr 2012 20:53:23 +0200 [thread overview]
Message-ID: <20120418185323.GA30118@uio.no> (raw)
In-Reply-To: <4F8F0A12.6070309@gmx.de>
On Wed, Apr 18, 2012 at 08:38:10PM +0200, Ninja wrote:
> sorry for the late response. Unfortunately my Skystar HD2 died on me
> and it looks like i get an other card in exchange.
> Anyway, as far I could test, the patches were ok to me. I can still
> put my marks, but I'm not sure which ones I should use or I'm
> allowed to use.
All except 01 (IRQ0 handling) and 11 (enable CA) are written by me. 01 should
probably be safe (it's already pending review here); 11 is more unclear.
Anyway, I'm sure 11 is pretty trivial once it's cleaned up, so someone should
just rewrite it without the part that moves a function around, and I'm sure
it can go in.
02, 04 and 06 are fixes for debugging output only. They should be safe.
03 (dvbdev mutex) should probably be fixed in a more general way, by someone
more knowledgeable of the DVB subsystem.
06 and 08 are general cleanups. They should be pretty safe.
07 (atomic accesses) contains important SMP fixes. Should definitely go in.
09 and 10 contain fixes for IRQ0 timeouts on SMP. They should go in, but only
as a pair; if you do 09 without 10, you will unmask a lot of the timeouts
that are there. (09 doesn't introduce any new timeouts, it just makes
userspace see them properly, and as an end result, things get worse.)
So, as a start, pull 01, 02, and 04 through 10? We'll still be without CA
support, but as a whole the Mantis driver will be better.
/* Steinar */
--
Homepage: http://www.sesse.net/
prev parent reply other threads:[~2012-04-18 18:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 15:53 [PATCH] Various fixes, hacks and patches for Mantis CA support Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 01/11] Don't reset IRQ0 if it's not already set Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 02/11] Clear out MANTIS_INT_RISCSTAT when printing status bits Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 03/11] Hack to fix a mutex issue in the DVB layer Steinar H. Gunderson
2012-04-11 2:17 ` Mauro Carvalho Chehab
2012-04-01 15:53 ` [PATCH 04/11] Show timeouts on I2C transfers Steinar H. Gunderson
2012-04-04 15:43 ` Marko Ristola
2012-04-04 16:32 ` Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 05/11] Slightly more friendly debugging output Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 06/11] Replace ca_lock by a slightly more general int_stat_lock Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 07/11] Fix a ton of SMP-unsafe accesses Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 08/11] Remove some unused structure members Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 09/11] Correct wait_event_timeout error return check Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 10/11] Ignore timeouts waiting for the IRQ0 flag Steinar H. Gunderson
2012-04-01 15:53 ` [PATCH 11/11] Enable Mantis CA support Steinar H. Gunderson
2012-04-18 18:38 ` [PATCH] Various fixes, hacks and patches for " Ninja
2012-04-18 18:53 ` Steinar H. Gunderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418185323.GA30118@uio.no \
--to=sgunderson@bigfoot.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).