From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:55565 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198Ab2DSPIU (ORCPT ); Thu, 19 Apr 2012 11:08:20 -0400 Date: Thu, 19 Apr 2012 16:08:13 +0100 From: Luis Henriques To: Mauro Carvalho Chehab Cc: Jarod Wilson , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] [media] ite-cir: postpone ISR registration Message-ID: <20120419150813.GA22948@zeus> References: <1334782447-8742-1-git-send-email-luis.henriques@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1334782447-8742-1-git-send-email-luis.henriques@canonical.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, Apr 18, 2012 at 09:54:07PM +0100, Luis Henriques wrote: > An early registration of an ISR was causing a crash to several users (for > example here: http://bugs.launchpad.net/bugs/972723 The reason was that > IRQs were being triggered before the driver initialisation was completed. > > This patch fixes this by moving the invocation to request_irq() to a later > stage on the driver probe function. > > Signed-off-by: Luis Henriques > --- > drivers/media/rc/ite-cir.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c > index 682009d..98d8ccf 100644 > --- a/drivers/media/rc/ite-cir.c > +++ b/drivers/media/rc/ite-cir.c > @@ -1521,10 +1521,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id > dev_desc->io_region_size, ITE_DRIVER_NAME)) > goto failure; > > - if (request_irq(itdev->cir_irq, ite_cir_isr, IRQF_SHARED, > - ITE_DRIVER_NAME, (void *)itdev)) > - goto failure; > - > /* set driver data into the pnp device */ > pnp_set_drvdata(pdev, itdev); > itdev->pdev = pdev; > @@ -1600,6 +1596,10 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id > rdev->driver_name = ITE_DRIVER_NAME; > rdev->map_name = RC_MAP_RC6_MCE; > > + if (request_irq(itdev->cir_irq, ite_cir_isr, IRQF_SHARED, > + ITE_DRIVER_NAME, (void *)itdev)) > + goto failure; > + > ret = rc_register_device(rdev); > if (ret) > goto failure; > -- > 1.7.9.5 I completely forgot to add: Cc: to my email. Cheers, -- Luis