From: Jarod Wilson <jarod@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: mchehab@redhat.com, linux-media@vger.kernel.org
Subject: Re: [media] fintek-cir: add support for newer chip version
Date: Thu, 19 Apr 2012 16:41:16 -0400 [thread overview]
Message-ID: <20120419204116.GA5165@redhat.com> (raw)
In-Reply-To: <20120419172510.GA14649@elgon.mountain>
On Thu, Apr 19, 2012 at 08:25:10PM +0300, Dan Carpenter wrote:
> Hi Mauro,
>
> The patch 83ec8225b6ae: "[media] fintek-cir: add support for newer
> chip version" from Feb 14, 2012, leads to the following warning:
> drivers/media/rc/fintek-cir.c:200 fintek_hw_detect()
> warn: known condition '1032 != 2052'
>
> drivers/media/rc/fintek-cir.c
> 197 /*
> 198 * Newer reviews of this chipset uses port 8 instead of 5
> 199 */
> 200 if ((chip != 0x0408) || (chip != 0x0804))
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> One of these conditions is always true.
>
> Probably it should it be:
> if ((chip == 0x0408) || (chip == 0x0804))
> or:
> if ((chip != 0x0408) && (chip != 0x0804))
Reasonably sure the latter case would be the proper one there.
> depending one if those are the newer or the older chipsets. I googled
> for it a bit and then decided to just email you. :P
>
> 201 fintek->logical_dev_cir = LOGICAL_DEV_CIR_REV2;
> 202 else
> 203 fintek->logical_dev_cir = LOGICAL_DEV_CIR_REV1;
> 204
>
> regards,
> dan carpenter
>
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2012-04-19 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 17:25 [media] fintek-cir: add support for newer chip version Dan Carpenter
2012-04-19 20:41 ` Jarod Wilson [this message]
2012-04-19 20:46 ` Mauro Carvalho Chehab
2012-04-22 8:06 ` [patch] [media] fintek-cir: change || to && Dan Carpenter
2012-04-23 14:17 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120419204116.GA5165@redhat.com \
--to=jarod@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).