From: Jean-Francois Moine <moinejf@free.fr>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.
Date: Sat, 5 May 2012 19:24:05 +0200 [thread overview]
Message-ID: <20120505192405.18bb588e@tele> (raw)
In-Reply-To: <4FA541B8.4080507@redhat.com>
On Sat, 05 May 2012 17:05:28 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> > Now I see that we are doing exactly that in for example vidioc_g_jpegcomp in gspca.c, so
> > we should stop doing that. We can make vidioc_g/s_jpegcomp only do the usb locking if
> > gspca_dev->vdev.ctrl_handler == NULL, and once all sub drivers are converted simply remove
> > it. Actually I'm thinking about making the jpegqual control part of the gspca_dev struct
> > itself and move all handling of vidioc_g/s_jpegcomp out of the sub drivers and into
> > the core.
>
> Here is an updated version of this patch implementing this approach for
> vidioc_g/s_jpegcomp. We may need to do something similar in other places, although I cannot
> think of any such places atm,
As the JPEG parameters have been redefined as standard controls, and as
there should be only a very few applications which use it, I think the
vidioc_g/s_jpegcomp code could be fully removed.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2012-05-05 17:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 15:09 [RFCv1 PATCH 0/7] gspca: allow use of control framework and other fixes Hans Verkuil
2012-04-28 15:09 ` [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework Hans Verkuil
2012-04-28 15:09 ` [RFCv1 PATCH 2/7] zc3xx: convert to " Hans Verkuil
2012-05-05 14:35 ` Hans de Goede
2012-04-28 15:09 ` [RFCv1 PATCH 3/7] sn9c20x: " Hans Verkuil
2012-04-28 15:09 ` [RFCv1 PATCH 4/7] gspca: use video_drvdata(file) instead of file->private_data Hans Verkuil
2012-04-28 15:09 ` [RFCv1 PATCH 5/7] gscpa: use v4l2_fh and add G/S_PRIORITY support Hans Verkuil
2012-04-28 15:09 ` [RFCv1 PATCH 6/7] gspca: add support for control events Hans Verkuil
2012-04-28 15:09 ` [RFCv1 PATCH 7/7] gspca: fix querycap and incorrect return codes Hans Verkuil
2012-05-05 7:43 ` [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework Hans de Goede
2012-05-05 8:34 ` Hans Verkuil
2012-05-05 14:46 ` Hans de Goede
2012-05-05 14:50 ` Hans Verkuil
2012-05-05 14:59 ` Hans de Goede
2012-05-05 17:20 ` Jean-Francois Moine
2012-05-05 9:14 ` Hans Verkuil
2012-05-05 14:44 ` Hans de Goede
2012-05-05 15:02 ` Hans Verkuil
2012-05-05 15:41 ` Hans de Goede
2012-05-05 15:05 ` Hans de Goede
2012-05-05 15:40 ` Hans de Goede
2012-05-05 17:24 ` Jean-Francois Moine [this message]
2012-04-30 11:13 ` [RFCv1 PATCH 0/7] gspca: allow use of control framework and other fixes Hans de Goede
2012-05-01 10:28 ` Jean-Francois Moine
2012-05-05 7:38 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120505192405.18bb588e@tele \
--to=moinejf@free.fr \
--cc=hans.verkuil@cisco.com \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox