linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] gspca: kinect cleanup, ov534 port to control framework
@ 2012-05-16 21:42 Antonio Ospite
  2012-05-16 21:42 ` [PATCH 1/3] gspca_kinect: remove traces of the gspca control mechanism Antonio Ospite
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Antonio Ospite @ 2012-05-16 21:42 UTC (permalink / raw)
  To: linux-media
  Cc: Antonio Ospite, Hans de Goede, Hans Verkuil, Jean-Francois Moine

Hi,

the first patch just removes traces of the gspca control handling
mechanism from the kinect driver; this driver does not have any
controls. The change is trivial and can be applied right away, or
postponed to when the gspca_main code is removed, you decide.

The second patch removes the dependency between auto gain and auto white
balance, I'd like to hear Jean-Francois on this, the webcam (the ov772x
sensor) is able to set the two parameters independently and the user can
see the difference of either, is there a reason why we were preventing
the user from doing so before?

The third patch is the conversion of the ov534 subdriver to the v4l2
control framework, I tested the code with a PS3 Eye (ov772x sensor) and
it works fine (now disabling automatic exposure works too, yay), maybe
someone else can give it a run on a webcam with OV767x.

NOTE: in patch 3, in sd_init_controls(), I left multiple checks

	if (sd->sensor == SENSOR_OV772x)

just to preserve the order the controls were declared in "struct sd", if
you feel the order is not that important I can aggregate the checks,
just let me know, it just looked neater to me this way.


>From a purely aesthetic point of view maybe the gspca mechanism of
defining controls was prettier, more declarative, but the control
framework really looks "more correct" even from userspace, qv4l2 can now
display labels of control classes in tabs automatically while before we
had empty labels, disabled controls in clusters work beautifully, and
disabled controls with associated automatic settings can show the value
calculated by the hardware on every update, very instructive if not
super-useful.

Thanks,
   Antonio

Antonio Ospite (3):
  gspca - kinect: remove traces of gspca control handling
  gspca - ov534: make AGC and AWB controls independent
  gspca - ov534: convert to v4l2 control framework

 drivers/media/video/gspca/kinect.c |    9 -
 drivers/media/video/gspca/ov534.c  |  590 ++++++++++++++++--------------------
 2 files changed, 261 insertions(+), 338 deletions(-)

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-05-18 12:30 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-16 21:42 [PATCH 0/3] gspca: kinect cleanup, ov534 port to control framework Antonio Ospite
2012-05-16 21:42 ` [PATCH 1/3] gspca_kinect: remove traces of the gspca control mechanism Antonio Ospite
2012-05-16 21:42 ` [PATCH 2/3] gspca_ov534: make AGC and AWB controls independent Antonio Ospite
2012-05-16 21:42 ` [PATCH 3/3] gspca_ov534: Convert to the control framework Antonio Ospite
2012-05-18  7:08 ` [PATCH 0/3] gspca: kinect cleanup, ov534 port to " Jean-Francois Moine
2012-05-18 11:38   ` Antonio Ospite
2012-05-18 12:30 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).