* [PATCH] lg2160: fix off-by-one error in lg216x_write_regs
@ 2012-05-21 15:34 Michael Krufky
2012-05-21 15:58 ` Michael Krufky
0 siblings, 1 reply; 4+ messages in thread
From: Michael Krufky @ 2012-05-21 15:34 UTC (permalink / raw)
To: linux-media; +Cc: Dan Carpenter, Michael Krufky
Fix an off-by-one error in lg216x_write_regs, causing the last element
of the lg216x init block to be ignored. Spotted by Dan Carpenteter.
Thanks-to: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
---
drivers/media/dvb/frontends/lg2160.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb/frontends/lg2160.c b/drivers/media/dvb/frontends/lg2160.c
index a3ab1a5..cc11260 100644
--- a/drivers/media/dvb/frontends/lg2160.c
+++ b/drivers/media/dvb/frontends/lg2160.c
@@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,
lg_reg("writing %d registers...\n", len);
- for (i = 0; i < len - 1; i++) {
+ for (i = 0; i < len; i++) {
ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
if (lg_fail(ret))
return ret;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] lg2160: fix off-by-one error in lg216x_write_regs
2012-05-21 15:34 [PATCH] lg2160: fix off-by-one error in lg216x_write_regs Michael Krufky
@ 2012-05-21 15:58 ` Michael Krufky
2012-05-21 16:05 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Michael Krufky @ 2012-05-21 15:58 UTC (permalink / raw)
To: linux-media; +Cc: Dan Carpenter, Michael Krufky
eeek! spelling error in dan's name! my apologies. I will correct
this in my tree before I ask Mauro to merge it.
-Mike
On Mon, May 21, 2012 at 11:34 AM, Michael Krufky <mkrufky@kernellabs.com> wrote:
> Fix an off-by-one error in lg216x_write_regs, causing the last element
> of the lg216x init block to be ignored. Spotted by Dan Carpenteter.
>
> Thanks-to: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
> ---
> drivers/media/dvb/frontends/lg2160.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb/frontends/lg2160.c b/drivers/media/dvb/frontends/lg2160.c
> index a3ab1a5..cc11260 100644
> --- a/drivers/media/dvb/frontends/lg2160.c
> +++ b/drivers/media/dvb/frontends/lg2160.c
> @@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,
>
> lg_reg("writing %d registers...\n", len);
>
> - for (i = 0; i < len - 1; i++) {
> + for (i = 0; i < len; i++) {
> ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
> if (lg_fail(ret))
> return ret;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] lg2160: fix off-by-one error in lg216x_write_regs
@ 2012-05-21 16:06 Michael Krufky
0 siblings, 0 replies; 4+ messages in thread
From: Michael Krufky @ 2012-05-21 16:06 UTC (permalink / raw)
To: linux-media; +Cc: Dan Carpenter, Michael Krufky
Fix an off-by-one error in lg216x_write_regs, causing the last element
of the lg216x init block to be ignored. Spotted by Dan Carpenter.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
---
drivers/media/dvb/frontends/lg2160.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb/frontends/lg2160.c b/drivers/media/dvb/frontends/lg2160.c
index a3ab1a5..cc11260 100644
--- a/drivers/media/dvb/frontends/lg2160.c
+++ b/drivers/media/dvb/frontends/lg2160.c
@@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state,
lg_reg("writing %d registers...\n", len);
- for (i = 0; i < len - 1; i++) {
+ for (i = 0; i < len; i++) {
ret = lg216x_write_reg(state, regs[i].reg, regs[i].val);
if (lg_fail(ret))
return ret;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-21 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-21 15:34 [PATCH] lg2160: fix off-by-one error in lg216x_write_regs Michael Krufky
2012-05-21 15:58 ` Michael Krufky
2012-05-21 16:05 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 16:06 Michael Krufky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).